-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Computational Art #5
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good overall! You went beyond the minimum requirement and generated a bunch of cool images. Your code is well-documented and is easy to follow. Nicely done! The only suggestion for you is to write more unit tests!
|
||
|
||
def build_random_function(min_depth, max_depth): | ||
def build_random_function(min_depth, max_depth, movie): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extension! 👍
functions = ['prod', 'avg', 'acos_pi', 'asin_pi', 'cos_pi', 'sin_pi', 'cubed'] # possible operations | ||
|
||
if movie: | ||
variables = [['x'],['y'],['t']] # three variables when making a movie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice that you are explaining this in a inline comment
|
||
|
||
def evaluate_random_function(f, x, y): | ||
|
||
def evaluate_random_function(f, x, y, t): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend that you add more unit tests of your own to test functions like this in future projects.
No description provided.