Open
Conversation
16 tasks
TanmayArya-1p
force-pushed
the
snapshot
branch
from
30521a0 to
756766a
Compare
TanmayArya-1p
commented
Feb 4, 2026
| } | ||
|
|
||
| #[test] | ||
| fn test_create_and_load_snapshot() { |
Member
Author
There was a problem hiding this comment.
these tests give an overview of how the snapshots api is to be used
4adex
reviewed
Mar 9, 2026
Collaborator
4adex
left a comment
4adex
left a comment
There was a problem hiding this comment.
Fix error handling in these certain places
| .lock() | ||
| .unwrap() | ||
| .add_snapshot(&snapshot_path) | ||
| .unwrap(); |
Collaborator
There was a problem hiding this comment.
Propagate error or panic if needed but don't use excessive unwraps. Also check other unwraps in engine. (unwraps are okay in tests only)
| "Storage checkpoint was not properly made".to_string(), | ||
| ))? | ||
| .to_str() | ||
| .unwrap() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #38