Merged
Conversation
Contributor
Author
|
@albireox It looks like the above changes worked for Mike and I's needs. Can we merge and tag? Or are there changes on main that would make that not work quite yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue in correctly accounting for all the flags when calculating the offset value. It does it on a per magnitude basis and then takes the maximum offset. The exception should be if there is a flag = 32 for one of the magnitudes (signals too bright for our offset limit), then the delta_ra returned should be 0 and the flag above reflect that it is invalid. This was not done properly previously. These changes fix this.
We do need to merged and tagged for the iota run. Everything looks good according to my tests. I am waiting for Mike to respond to make sure all of the changes work on his end.