Adds an option to force relative paths.#215
Open
iamnoderbx wants to merge 1 commit intoseaofvoices:mainfrom
Open
Adds an option to force relative paths.#215iamnoderbx wants to merge 1 commit intoseaofvoices:mainfrom
iamnoderbx wants to merge 1 commit intoseaofvoices:mainfrom
Conversation
Author
|
Please note this is my first contribution to a rust project, I wanted to keep it simple, but I do find that this will have quite a bit of positive impact. A very simple change in which can allow a handful of more use-cases for darklua. |
|
With the introduction of Roblox supported relative-only string paths, I feel this kind of feature is more helpful than ever. I hope it's merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #214
Allows for Darklua to be used for Projects in cross-environment scenarios, as well as plugin development
The only change is this implements a new boolean to the transform require rule: "force_relative_path", which simply forces a path to be relative to the script the transformation is occurring on. See the examples below.
Example
Wasn't entirely sure the best approach for implementing a test for this, however all previous tests work - which at bare minimum allows for compatibility and ease for updating. If you have any advice let me know.