-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
bluetooth: Add version and company identifiers to local version commands #4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dc0cb7e
to
42dc38e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
- Coverage 82.20% 82.16% -0.04%
==========================================
Files 361 343 -18
Lines 87195 86924 -271
==========================================
- Hits 71679 71424 -255
+ Misses 15516 15500 -16
🚀 New features to boost your workflow:
|
It would probably be good to add a comment pointing to https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml where the company identifiers come from, so they can be more easily updated in the future (since they change very frequently). |
0c4291e
to
db0a570
Compare
Hi, sorry for the delay. I think that this should be moved to someplace else as it makes bluetooth.py a bit unreadable. Ideally it would be stored similarly to How does that sound? |
db0a570
to
27aaa27
Compare
Sorry for the delay. Went the easy route and moved the dict to data. :) |
27aaa27
to
4456378
Compare
Checklist:
cd test && ./run_tests
ortox
)Just adds more information to the HCI_Cmd_Complete_Read_Local_Version_Information packet :)