Skip to content

Update utils.py to forward size parameter in RawPcapnpReader #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StempunkDev
Copy link

I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk

Checklist:

  • I executed the regression tests (using cd test && ./run_tests or tox)

RawPcapNgReader will now forward size to lower level parsing, allowing for configuration to trickle down
Default state is not touched.
Unit tests should ideally not be effected by this

There should be no impact in other parts of the library

I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (d947ff1) to head (63794fd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4721      +/-   ##
==========================================
- Coverage   82.12%   78.56%   -3.56%     
==========================================
  Files         361      336      -25     
  Lines       87079    81872    -5207     
==========================================
- Hits        71510    64323    -7187     
- Misses      15569    17549    +1980     

see 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant