Skip to content

Fix #4717 & cleanup NTP control#4791

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:ntp-fix
Jul 17, 2025
Merged

Fix #4717 & cleanup NTP control#4791
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:ntp-fix

Conversation

@gpotter2

Copy link
Copy Markdown
Member

fixes #4717

@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (0f7b0c0) to head (beaa903).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/ntp.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4791   +/-   ##
=======================================
  Coverage   81.02%   81.03%           
=======================================
  Files         365      365           
  Lines       89068    89024   -44     
=======================================
- Hits        72170    72138   -32     
+ Misses      16898    16886   -12     
Files with missing lines Coverage Δ
scapy/layers/ntp.py 87.65% <92.30%> (+2.32%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit b60b29b into secdev:master Jul 17, 2025
24 checks passed
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NTP parsing of status response is incorrect

1 participant