packit: allow SHA-1 signatures when tests are run#4796
Merged
Conversation
The "PrivKey class : resign cert" test fails on Fedora because SHA-1 signatures are deprecated there: https://fedoraproject.org/wiki/SHA1SignaturesGuidance. Since it's Fedora-specific and the test failure is useful in terms of detecting it and deciding how to address it in programs that use scapy in environments like that it should be enough to allow SHA-1 signatures on Packit only. Closes secdev#4794
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4796 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 365 365
Lines 89027 89027
=======================================
Hits 72143 72143
Misses 16884 16884 🚀 New features to boost your workflow:
|
guedou
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "PrivKey class : resign cert" test fails on Fedora because SHA-1 signatures are deprecated there:
https://fedoraproject.org/wiki/SHA1SignaturesGuidance. Since it's Fedora-specific and the test failure is useful in terms of detecting it and deciding how to address it in programs that use scapy in environments like that it should be enough to allow SHA-1 signatures on Packit only.
Closes #4794
(The testsuite still fails there on big-endian machines but it's unrelated: #4793)