Skip to content

Added ASN.1 UPER and OER encoding#5031

Open
polybassa wants to merge 12 commits into
secdev:masterfrom
polybassa:v2x
Open

Added ASN.1 UPER and OER encoding#5031
polybassa wants to merge 12 commits into
secdev:masterfrom
polybassa:v2x

Conversation

@polybassa

Copy link
Copy Markdown
Contributor

This encoders are a preparation to support V2X / C-ITS communication in Scapy.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.89590% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.46%. Comparing base (2498fbb) to head (16e4d80).

Files with missing lines Patch % Lines
scapy/asn1/uper.py 89.15% 78 Missing ⚠️
scapy/asn1/oer.py 87.73% 53 Missing ⚠️
scapy/asn1fields.py 89.48% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5031      +/-   ##
==========================================
+ Coverage   80.22%   80.46%   +0.23%     
==========================================
  Files         387      389       +2     
  Lines       96450    97971    +1521     
==========================================
+ Hits        77381    78835    +1454     
- Misses      19069    19136      +67     
Files with missing lines Coverage Δ
scapy/all.py 100.00% <100.00%> (ø)
scapy/asn1/ber.py 96.62% <100.00%> (+13.90%) ⬆️
scapy/asn1fields.py 92.62% <89.48%> (+8.98%) ⬆️
scapy/asn1/oer.py 87.73% <87.73%> (ø)
scapy/asn1/uper.py 89.15% <89.15%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .config/ci/install.ps1 Outdated
python -m pip install -U tox --ignore-installed

# Optional test dependency for ASN.1 OER interoperability tests
python -m pip install asn1tools

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, can we avoid this?

I'd rather have barcoded bytes strings as unit tests, but I don't think it's necessary to have a lib for that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry that this PR became so huge. I hope there is a way forward to get it merged.

Nils Weiss added 12 commits July 7, 2026 17:24
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Sonnet 5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants