Depth-splice rigged attachment alpha into world alpha#5927
Open
Viscerous wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, alpha sorting happens in two passes: rigged first via raw pointers, which is non-deterministic, and then a back to front walk for unrigged. Since the passes are separate, rigged (which includes almost all avatars) will interact poorly with the rest of the world (almost entirely unrigged) resulting in long-standing issues such as avatars' hair in the foreground rejecting trees in the background. The pointer-based rigged pass will also almost always favour a user's own avatar, resulting in differences between what one person sees locally vs. others.
Since we already deterministically sort rigged intra-avatar attachments via the attachment slots, I propose interleaving whole avatars by their root together with the unrigged walk in one unified pass, giving both a proper order. Hair will no longer reject alpha objects behind it, or vice versa.
Since this reduces one pass, net is likely slightly less work on the CPU-side and neutral on the GPU save for the overdraw of the previously undrawn pixels.
2026-06-15.18-07-48.mp4