Skip to content

Conversation

zhengyao-lin
Copy link
Member

I noticed that the original parse_help still gets compiled to a recursive function. So I replaced it with a loop instead. No particular performance impact though.

@y1ca1
Copy link
Collaborator

y1ca1 commented Dec 20, 2024

  1. Does it make sense to remove the parse_helper entirely?
  2. For consistency, do we want serialize to be a loop as well?

@zhengyao-lin
Copy link
Member Author

  1. Yeah probably;
  2. Makes sense; will get to that at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants