Open
Conversation
Upgrade to cosmwasm 1.0
Upgrade cosmwasm 1 0
DrPresident
reviewed
Nov 1, 2022
Contributor
There was a problem hiding this comment.
Can we format these files? there are alot of instances of 2-5 newlines in a row, as well as trailing newlines on files. We use this rustfmt.toml in the shade repo
# https://github.com/rust-lang/rustfmt/blob/master/Configurations.md
# Stable configurations
edition = "2018"
max_width = 100
merge_derives = true
use_field_init_shorthand = true
use_try_shorthand = true
# Nightly configurations
imports_layout = "HorizontalVertical"
imports_granularity = "Crate"
overflow_delimited_expr = true
reorder_impl_items = true
version = "Two"
Comment on lines
+163
to
+167
| let _response = router.execute_contract( | ||
| owner_addr.to_owned(), | ||
| &router_contract, | ||
| &execute_swap, | ||
| &[]); |
Contributor
There was a problem hiding this comment.
Should probably be verifying the results of these swaps
Feature/multitest
Feature/multitest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.