Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match vite render API to the webpack api #1222

Merged
merged 22 commits into from
Mar 26, 2025
Merged

Conversation

DanDroryAu
Copy link
Contributor

Outline

the initial implementation of experimental vite support came with a changed API. In order to get feature parity and make the transition from webpack to vite smooth in the future the API of experimental vite should match that of the current webpack API. This PR aims to make that improvement.

The larger change here is in the vite middleware that runs the dev server and transforms the index.html file when requested.

Changes

Add additional log information for rendering middleware and loadable.

Change vite render api to match that of webpack.
Change suspense fixture, allowing both vite and webpack bundling.
Change suspense test to run for both vite and webpack.
Change type for Render and added a new LibraryRender type.

Remove sections of the docs that are outdated regarding vite migration.
Remove the vite-test-app fixture. This fixture was only there for internal testing. With these new changes we can start applying vite on the existing fixtures.

Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 7b48b62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanDroryAu DanDroryAu marked this pull request as ready for review March 25, 2025 03:09
@DanDroryAu DanDroryAu requested a review from a team as a code owner March 25, 2025 03:09
@DanDroryAu DanDroryAu requested a review from askoufis March 25, 2025 23:27
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset

@DanDroryAu DanDroryAu requested a review from askoufis March 26, 2025 03:26
@DanDroryAu DanDroryAu merged commit eedaa2d into master Mar 26, 2025
4 checks passed
@DanDroryAu DanDroryAu deleted the render-document-api-vite branch March 26, 2025 03:28
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants