-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match vite render API to the webpack api #1222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-document-api-vite
🦋 Changeset detectedLatest commit: 7b48b62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
Mar 25, 2025
askoufis
reviewed
Mar 25, 2025
askoufis
reviewed
Mar 25, 2025
packages/sku/src/services/vite/helpers/html/createPreRenderedHtml.tsx
Outdated
Show resolved
Hide resolved
askoufis
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changeset
packages/sku/src/services/vite/plugins/skuViteMiddlewarePlugin.ts
Outdated
Show resolved
Hide resolved
askoufis
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline
the initial implementation of experimental
vite
support came with a changed API. In order to get feature parity and make the transition fromwebpack
tovite
smooth in the future the API of experimentalvite
should match that of the currentwebpack
API. This PR aims to make that improvement.The larger change here is in the
vite
middleware that runs the dev server and transforms the index.html file when requested.Changes
Add additional log information for
rendering
middleware
andloadable
.Change vite render api to match that of webpack.
Change
suspense
fixture, allowing both vite and webpack bundling.Change
suspense
test to run for both vite and webpack.Change type for
Render
and added a newLibraryRender
type.Remove sections of the docs that are outdated regarding vite migration.
Remove the
vite-test-app
fixture. This fixture was only there for internal testing. With these new changes we can start applyingvite
on the existing fixtures.