Skip to content

[Smart Hashing] Add eslint rule to limit usage of createHash from crypto module #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

[Smart Hashing] Add eslint rule to limit usage of createHash from crypto module #2861

merged 2 commits into from
May 7, 2025

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Apr 8, 2025 •
edited
Loading

This PR adds a Es lint rule that restricts the usage of createHash from crypto module, to encourage the usage of Smart hashing module for hashing.

For other usage of Crypto module, Eslint disable is added.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner April 8, 2025 12:01
@harsh-joshi99 harsh-joshi99 mentioned this pull request Apr 8, 2025
Closed
5 tasks
varadarajan-tw
varadarajan-tw previously approved these changes Apr 9, 2025
View reviewed changes
.eslintrc.js Outdated
{
selector: "ImportDeclaration[source.value='crypto'] ImportSpecifier[imported.name='createHash']",
message:
'Avoid importing the "createHash" function from "crypto". Use "destination-actions/lib/hashing-utils" instead.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention why they need to use hashing-utils and when?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Avoid importing the "createHash" function from "crypto". Use "destination-actions/lib/hashing-utils" instead.'
'The "destination-actions/lib/hashing-utils/processHashing" can autodetect prehashed values and avoid double hashing [link to doc]. Avoid importing the "createHash" function from "crypto"'

@codecov Codecov
Copy link

codecov bot commented Apr 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (7a40bef) to head (34605d1).
Report is 40 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
+ Coverage   77.61%   77.93%   +0.32%     
==========================================
  Files        1047     1047              
  Lines       19219    19246      +27     
  Branches     3750     3751       +1     
==========================================
+ Hits        14916    14999      +83     
+ Misses       2992     2925      -67     
- Partials     1311     1322      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh-joshi99 harsh-joshi99 merged commit 8f04e9a into main May 7, 2025
14 checks passed
@harsh-joshi99 harsh-joshi99 deleted the smart-hashing/lint-rule branch May 7, 2025 06:09
nick-Ag added a commit that referenced this pull request May 14, 2025
@nick-Ag
Squashed commit of the following:
aa7623b 
commit 9a00688
Author: Nick Aguilar <[email protected]>
Date:   Wed May 14 11:11:28 2025 -0700

    liquidjs stub file

commit 06610c7
Author: Nick Aguilar <[email protected]>
Date:   Wed May 14 11:11:16 2025 -0700

    Aliases liquid.js to a stub file to disable it for browser

commit 1f6ab3f
Author: Nick Aguilar <[email protected]>
Date:   Tue May 13 10:11:13 2025 -0700

    Moves liquid unit testing to it's own file so that it's not tested alongside browser tests

commit 765c3f1
Author: Nick Aguilar <[email protected]>
Date:   Mon May 12 12:41:38 2025 -0700

    Removes .only for tests

commit 2ebdd80
Author: Nick Aguilar <[email protected]>
Date:   Mon May 12 12:40:47 2025 -0700

    DoS protections configured

commit 32813f5
Author: Nick Aguilar <[email protected]>
Date:   Mon May 12 12:40:22 2025 -0700

    More coverage around basic usages

commit 06bdd79
Author: Nick Aguilar <[email protected]>
Date:   Mon May 12 12:16:34 2025 -0700

    Bumps liquidjs to 10.21.0

commit 1405917
Author: Nick Aguilar <[email protected]>
Date:   Fri May 9 12:05:22 2025 -0700

    Ensures correct string data type for liquid template

commit b7d28ef
Author: Nick Aguilar <[email protected]>
Date:   Fri May 9 11:39:53 2025 -0700

    Implements list of disabled filters and tags + unit tests

commit e151f22
Author: Nick Aguilar <[email protected]>
Date:   Wed May 7 11:07:04 2025 -0700

    WIP - simplest possible passing unit tests

commit e2ab04d
Author: Nick Aguilar <[email protected]>
Date:   Wed May 7 10:08:14 2025 -0700

    WIP - simple first unit test

commit 09ed757
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed May 7 14:18:04 2025 +0530

    Publish (#2901)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 36bcb1e
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 13:17:48 2025 +0530

    [Smart Hashing] Cleanup (#2879)

    * cleanup for smart hashing

    * Update reddit conversions test case

commit bb3b5f1
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 12:27:23 2025 +0530

    [Smart Hashing] Cleanup (#2877)

    * cleanup for smart hashing

    * Remove createHash from test file

commit 98f6a18
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:44:54 2025 +0530

    [Smart Hashing] Cleanup (#2876)

    * cleanup for smart hashing

    * cleanup for smart hashing

commit 8f04e9a
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:39:06 2025 +0530

    [Smart Hashing] Add eslint rule to limit usage of createHash from crypto module (#2861)

    * Add eslint rule to limit usage of createHash from crypto module

    * Update error message

commit efaeb6a
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:37:07 2025 +0530

    [Smart Hashing] Add smart hashing documentation in readme (#2860)

    * Add smart hashing documentation in readme

    * Update smart hashing documentation

    * update heading

    * update docs

    * Update smart hashing documentation

commit 0492630
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue May 6 13:10:55 2025 -0700

    Publish (#2900)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 14ed25d
Author: Felipe Rivera Cienfuegos <[email protected]>
Date:   Tue May 6 15:59:47 2025 -0400

    feat: vendorId in purchase (#2766)

commit bd1d18d
Author: Dan <[email protected]>
Date:   Tue May 6 22:59:03 2025 +0300

    Loops destination: ability to sync contact properties when sending events (#2792)

    * Added contact properties to Send event action

    * Type for contactProperties

    * Type for full payload

    * Update generated-types.ts

commit 584c81a
Author: ThabetIbrahim <[email protected]>
Date:   Tue May 6 22:58:50 2025 +0300

    Supporting Group event in Userpilot cloud destination (#2838)

commit 3cd1798
Author: Varadarajan V <[email protected]>
Date:   Wed May 7 01:28:33 2025 +0530

    [STRATCONN-5657] - Add batch keys to webhook action destination (#2878)

    * [STRATCONN-5657] - Add batch keys to webhook action destination

    * Add stats

    * Use histogram

    * Add test for batch keys

commit d61c50f
Author: Varadarajan V <[email protected]>
Date:   Wed May 7 01:28:16 2025 +0530

    [STRATCONN-5489] - Add batch_keys to Klaviyo actions (#2880)

    * [STRATCONN-5489] - Add batch_keys to Klaviyo actions

    * Fix build

    * UpsertProfile - add override_list_id to batch keys

    * Add stats to measure grouping

    * handle undefined statsclient

    * Fix tests

    * Add snapshot tests for batch keys

    * Remove unused stat

commit 58cd8d8
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 01:28:02 2025 +0530

    [Smart Hashing] [Liveramp Audiences] Cleanup (#2883)

    * cleanup for smart hashing

    * Update fb test to use processHashing.

    * Use processHashing instead of old hashing util

commit 860c3bb
Author: akhsueh <[email protected]>
Date:   Tue May 6 12:57:47 2025 -0700

    small updates to the default mappings in the Reddit CAPI integration (#2893)

    Co-authored-by: Austin Hsueh <[email protected]>

commit 512fe02
Author: Jacob Meyer <[email protected]>
Date:   Tue May 6 12:57:07 2025 -0700

    Add User-Agent header to Drip destination for source identification (#2897)

commit 471679b
Author: Joe Ayoub <[email protected]>
Date:   Tue May 6 20:56:35 2025 +0100

    adding new regions for Braze (#2896)

commit 05317de
Author: Arjun Bhandage <[email protected]>
Date:   Mon May 5 15:35:59 2025 +0530

    add hubspot objects (#2898)
valerieernst added a commit that referenced this pull request May 14, 2025
@valerieernst
Squashed commit of the following:
30522ea 
commit a4d1453
Author: Valerie Ernst <[email protected]>
Date:   Wed May 14 15:13:26 2025 -0700

    [STAGE ONLY] register warehouse testing destination

commit cb00836
Author: Neeharika Kondipati <[email protected]>
Date:   Wed May 14 13:26:21 2025 -0700

    Fix tests

commit cf18242
Author: Valerie Ernst <[email protected]>
Date:   Tue May 13 16:17:16 2025 -0700

    Use correct base object

commit 046e55d
Author: Valerie Ernst <[email protected]>
Date:   Tue May 13 16:08:33 2025 -0700

    Remove all mappings and just pass the event through

commit 02e9979
Merge: 5f87076 90998c5
Author: Valerie Ernst <[email protected]>
Date:   Tue May 13 16:02:19 2025 -0700

    Merge branch 'main' into warehouse-s3-destination

commit 90998c5
Author: Miguel Pavon Diaz <[email protected]>
Date:   Mon May 12 13:11:42 2025 -0400

    Update subscription presets and action descriptions for audience destinations for Journeys V2 (#2894)

    * Update subscription presets and action descriptions

    * Update the sync destination's description

    * Change 'Journeys Step Transition Track' to 'Journeys Step Entered'

commit 7d4dee8
Author: Arjun Bhandage <[email protected]>
Date:   Mon May 12 16:09:50 2025 +0530

    STRATCONN-5564: add quotes object support (#2910)

commit 09ed757
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed May 7 14:18:04 2025 +0530

    Publish (#2901)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 36bcb1e
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 13:17:48 2025 +0530

    [Smart Hashing] Cleanup (#2879)

    * cleanup for smart hashing

    * Update reddit conversions test case

commit bb3b5f1
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 12:27:23 2025 +0530

    [Smart Hashing] Cleanup (#2877)

    * cleanup for smart hashing

    * Remove createHash from test file

commit 98f6a18
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:44:54 2025 +0530

    [Smart Hashing] Cleanup (#2876)

    * cleanup for smart hashing

    * cleanup for smart hashing

commit 8f04e9a
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:39:06 2025 +0530

    [Smart Hashing] Add eslint rule to limit usage of createHash from crypto module (#2861)

    * Add eslint rule to limit usage of createHash from crypto module

    * Update error message

commit efaeb6a
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 11:37:07 2025 +0530

    [Smart Hashing] Add smart hashing documentation in readme (#2860)

    * Add smart hashing documentation in readme

    * Update smart hashing documentation

    * update heading

    * update docs

    * Update smart hashing documentation

commit 0492630
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue May 6 13:10:55 2025 -0700

    Publish (#2900)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 14ed25d
Author: Felipe Rivera Cienfuegos <[email protected]>
Date:   Tue May 6 15:59:47 2025 -0400

    feat: vendorId in purchase (#2766)

commit bd1d18d
Author: Dan <[email protected]>
Date:   Tue May 6 22:59:03 2025 +0300

    Loops destination: ability to sync contact properties when sending events (#2792)

    * Added contact properties to Send event action

    * Type for contactProperties

    * Type for full payload

    * Update generated-types.ts

commit 584c81a
Author: ThabetIbrahim <[email protected]>
Date:   Tue May 6 22:58:50 2025 +0300

    Supporting Group event in Userpilot cloud destination (#2838)

commit 3cd1798
Author: Varadarajan V <[email protected]>
Date:   Wed May 7 01:28:33 2025 +0530

    [STRATCONN-5657] - Add batch keys to webhook action destination (#2878)

    * [STRATCONN-5657] - Add batch keys to webhook action destination

    * Add stats

    * Use histogram

    * Add test for batch keys

commit d61c50f
Author: Varadarajan V <[email protected]>
Date:   Wed May 7 01:28:16 2025 +0530

    [STRATCONN-5489] - Add batch_keys to Klaviyo actions (#2880)

    * [STRATCONN-5489] - Add batch_keys to Klaviyo actions

    * Fix build

    * UpsertProfile - add override_list_id to batch keys

    * Add stats to measure grouping

    * handle undefined statsclient

    * Fix tests

    * Add snapshot tests for batch keys

    * Remove unused stat

commit 58cd8d8
Author: harsh-joshi99 <[email protected]>
Date:   Wed May 7 01:28:02 2025 +0530

    [Smart Hashing] [Liveramp Audiences] Cleanup (#2883)

    * cleanup for smart hashing

    * Update fb test to use processHashing.

    * Use processHashing instead of old hashing util

commit 860c3bb
Author: akhsueh <[email protected]>
Date:   Tue May 6 12:57:47 2025 -0700

    small updates to the default mappings in the Reddit CAPI integration (#2893)

    Co-authored-by: Austin Hsueh <[email protected]>

commit 512fe02
Author: Jacob Meyer <[email protected]>
Date:   Tue May 6 12:57:07 2025 -0700

    Add User-Agent header to Drip destination for source identification (#2897)

commit 471679b
Author: Joe Ayoub <[email protected]>
Date:   Tue May 6 20:56:35 2025 +0100

    adding new regions for Braze (#2896)

commit 05317de
Author: Arjun Bhandage <[email protected]>
Date:   Mon May 5 15:35:59 2025 +0530

    add hubspot objects (#2898)

commit 5f87076
Author: Valerie Ernst <[email protected]>
Date:   Mon Mar 3 09:45:07 2025 -0800

    Add warehouseId to settings and file name

commit 0f0de7b
Merge: 39d5ad4 f2ec6af
Author: Valerie Ernst <[email protected]>
Date:   Mon Mar 3 09:04:59 2025 -0800

    Merge branch 'main' into warehouse-s3-destination

commit 39d5ad4
Merge: 13dc722 8173184
Author: Valerie Ernst <[email protected]>
Date:   Thu Feb 20 11:42:06 2025 -0800

    Merge branch 'main' into warehouse-s3-destination

commit 13dc722
Author: Valerie Ernst <[email protected]>
Date:   Thu Feb 20 11:38:12 2025 -0800

    remove unused param

commit a8d08b1
Author: Valerie Ernst <[email protected]>
Date:   Wed Feb 19 16:51:22 2025 -0800

    Create temporary warehouse-test destination for poc of linked audience writeback
akhsueh pushed a commit to akhsueh/action-destinations that referenced this pull request May 16, 2025
@harsh-joshi99
[Smart Hashing] Add eslint rule to limit usage of createHash from cry…
a02c36c 
…pto module (segmentio#2861)

* Add eslint rule to limit usage of createHash from crypto module

* Update error message
joe-ayoub-segment added a commit that referenced this pull request May 28, 2025
@akhsueh @joe-ayoub-segment
@rvadera12 @nick-Ag @varadarajan-tw @itsarijitray @Innovative-GauravKochar @MarcDillar @jkaho @github-actions @mayur-pitale @guillaumefontan @jeffkayne @AnkitSegment @harsh-joshi99 @Copilot @drew-thompson @sayan-das-in @maryamsharif @victor-ru @jonathansudhakar1 @manuelnt11 @stevedrip @jacobpmeyer @GoodmanBen @julesbravo @pitronalldak @monutwilio @abhandage @ThabetIbrahim @danrowden @FelipeRiveraC @miguelpdiaz8
add phone number support to reddit-conversions-api (#2834)
d73a5a6 
* add phone number support to reddit-conversions-api

* Update order of mapping for phone numbers

Co-authored-by: Joe Ayoub <[email protected]>

* [Twilio-Messaging-Omnichannel] Register and set up Basic Authentication (#2827)

* Initial commit on branch

* Delete packages/destination-actions/src/destinations/twilio-messaging-omnichannel/__tests__/index.test.ts

* Delete packages/destination-actions/src/destinations/twilio-messaging-omnichannel/__tests__/snapshot.test.ts

* Delete packages/destination-actions/src/destinations/twilio-messaging-omnichannel/sendMessage/__tests__/snapshot.test.ts

* Delete packages/destination-actions/src/destinations/twilio-messaging-omnichannel/sendMessage/__tests__/index.test.ts

* [Salesforce] Advanced stats for CSV generation (#2825)

* WIP

* Adds stats around CSV generation. Counts the number of columns and rows. Counts the number of actual values and number of nulls for the whole CSV. Unit tests included

* Log out the CSV stats after the job is created to ensure the jobID is a defined tag

* [STRATCONN-5603] - Format timestamp fields without miliiseconds (#2816)

* [STRATCONN-5603] - Format timestamp fields without miliiseconds

* Revert type changes

* Revert type changes

* [GEC] Simplify convertTimestamp Regex

* Revert unintended change

* [STRATCONN-5601] add subscription object support for unsubscribeProfile action in Klaviyo (#2814)

* add subscription object support for unsubscribeProfile action in Klaviyo

* update snapshots

* add tests

* add tests

* fix comments

* Made Event properties hidden (#2813)

Co-authored-by: Gaurav Kochar <[email protected]>

* [Criteo] Audience Destination: set enable_batching to true by default (#2771)

* [Criteo] Audience Destination: set enable_batching to true by default

* Criteo Audience Destination: make 'Enable Batching' optional

* Criteo Audience Destination: updated generated types

---------

Co-authored-by: m.dillar <[email protected]>

* [algolia-insights] update presets for conversion events (#2770)

* deprecate Product Added

* update conversion presets

* fix

* Register twilio messaging omnichannel destination (#2829)

* Publish (#2830)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Support min/max string length validation (#2831)

* Passes on the InputField min and max properties to JSONSchema for validation

* Adds unit tests and updated comment descriptions for string field min/max

* [Salesforce Marketing Cloud] V2 Data Extension mapping save hook (#2826)

* Scaffolds new v2 actions

* Hook Definition and fields from the original branch

* dataExtensionV2 action filled out with the action definition from original branch

* contactdataExtensionV2 action filled out with the action definition from original branch

* Generates types

* Fixes build. Introduces an upsertRowsV2 function for the new actions

* Declares keys and values fields as dynamic only in the V2 actions to ensure no new behavior for the existing actions

* Adds a little (V2) suffix to the titles for the new actions

* Improves error message when users encounter auth issues for data extension id dynamic field

* When a user doesn't have auth permission to lookup a data extension, use the ID they provide without verifying it. Provide improved error messaging

* Throw an error if no data extension is connected to the mapping

* Eventbridge enhancements (#2828)

* Passes on the InputField min and max properties to JSONSchema for validation

* [required-field-check] Run yarn install after switching to main branch (#2801)

* [required-field-check] Run install after switching to main branch

* Add more comments

* Eventbridge cosmetic changes (#2807)

* Description changes

* Description changes

* additional enhancements

* eventbridge enhancements

* eventbridge enhancements

* changed Error to IntegrationError

---------

Co-authored-by: Nick Aguilar <[email protected]>
Co-authored-by: Varadarajan V <[email protected]>

* Publish (#2835)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [STRATCONN-5608] - Make ssl_enabled and ssl_reject_unauthorized_ca settings optional (#2832)

* Revert "Fix Test cases (#2538)" (#2844)

This reverts commit dda2c53.

* Update Trubrics action destination (#2784)

* Test

* Test

* update types

* final

* identify

* pr comments

* utils https

* add thread_id

* fix tests

---------

Co-authored-by: Jeff Kayne <[email protected]>

* [STRATCONN-5473] Add destinationInstanceID and subscriptionId to support audience fanout for Liveramp Audiences (#2786)

* [STRATCONN-5473] Add destinationInstanceID and subscriptionId to support audience fanout

* Revert Tradesk Changes

* handle file path edge cases

* handle file path edge cases

* Add Tests

* [SMART-HASHING] [STRATCONN-5636] Updated smart-hashing in delivrai-activate (#2836)

* Updated smart-hashing in delivrai-activate

* Updated unit test cases

* [Smart Hashing] [Snap Conversions API] Implement Smart hashing for Snap Conversions API (#2837)

* Implement Smart hashing for Snap Conversions API

* Return undefined from smart hash if hash field are not defined

* [SMART-HASHING] [STRATCONN-5637] Updated smart-hashing in dynamic-yield (#2839)

* Updated smart-hashing in dynamic-yield

* Removed email formating

* Fixed test cases

* Return undefined from smart hash if hash field are not defined (#2841)

* [Smart Hashing] [Snap Audience] Implement Smart hashing for Snap Audience (#2843)

* Implement Smart hashing for Snap Audience

* Remove console log

* Publish (#2845)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add hashedPII category to all fields that are hashed using process hashing (#2847)

* [Smart Hashing] Remove redundant hashing descriptions (#2848)

* [GEC] update description

* [Amazon AMC] Update description

* [Tiktok-offline-conversions] Update hashing description

* update generated-types

* Update packages/destination-actions/src/destinations/amazon-amc/syncAudiencesToDSP/index.ts

Co-authored-by: Copilot <[email protected]>

* [Amazon AMC] update types

---------

Co-authored-by: Copilot <[email protected]>

* Correct Presets for Linked Audience Activations

* Handles non-http error in SFMC multistatus handler (#2854)

* Handles non-http error in SFMC multistatus handler

* Update tests

* Update test case

* Amazon AMC - Increased http client timeout to 15 seconds (#2852)

* Publish (#2855)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Google Ads] Standardize Phone Number Formatting (#2810)

* [STRATCONN-5676] - Adds support braze web sdk - 5.8.1 (#2833)

* [STRATCONN-5602] - Sendgrid EU endpoint (#2849)

* [Sendgrid] Add support for EU endpoint

* Update sendEmail action to use regional endpoints

* Update uri format

* Add tests

* Add tests for dynamic fields

* Fix template content url

* Update Liveramp Docs (#2862)

* Update Liveramp Docs

* Update Liveramp Docs

* Update membership lifespan (#2863)

* Publish (#2864)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add mapping-kit labels and alert (#2867)

* Add error when no audience found (#2872)

* Angler AI - Add missing payload field  (#2818)

* initial commit

* fix failing tests

* updated saveUser action

* updated saveOrder action

* updated saveEvent action

* added action descriptions

* updated presets

* flattened saveEvent mapping

* fixed saveEvent.perform

* fixed saveEvent mapping

* updated snapshots

* updated snapshots

* fixed saveEvent payload structure

* don't include empty objects in payload

* updated

* progress

* restructure events

* remove defaults for optional fields

* restore address field

* update untranslated title default values

* updated snapshots

* remove unused import

* fixed default paths

* reorganized saveUser fields

* updated saveBaseEvent fields

* fixed default_address default in saveUser

* moved custom event name to saveBaseEvent

* updated tests

* added defaults for customer field in saveEvent

* test commit

* refactor fields

* consistent naming for fields variables

* removed cartFields from saveCartEvent

* removed less important saveOrder fields

* updated event names

* moved event name field from common fields

* fixed field name

* refactor event fields

* updated generated types

* updated tests

* fixed checkout fields

* updated payload transformation functions

* removed custom event preset

* fixed identifiers transformation

* updated tests

* wrapped cart and checkout fields into objects

* updated tests

* minor changes to presets

* added missing checkout event name

* fixed saveUser payload structure

* fixed typo

* updated tests

* fix customers endpoint url

* add preset for saveOrder

* add email and phone to checkout payload

* add billing and shipping address to checkout object

* update snapshots

* save line items

* update snapshots

* update tests for saveOrder

* generate line item id

* update snapshots

* add missing custom_event_name field to saveCustomEvent

---------

Co-authored-by: Jonathan Sudhakar <[email protected]>
Co-authored-by: Joe Ayoub <[email protected]>

* Add fs_user_id and web_user_id to Optimizely payload interfaces (#2789)

* Add fs_user_id and web_user_id to Optimizely payload interfaces

* Add fs_user_id and web_user_id fields to Optimizely user identifiers

* Generates types

* Updates unit test snapshots

* Manually sets snapshot expectation to address broken test

* Manually sets snapshot expectation to address broken test, again

---------

Co-authored-by: Manuel Nuñez <[email protected]>
Co-authored-by: Nick Aguilar <[email protected]>

* Publish (#2882)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added MultiStatus Documentation (#2886)

* Fix MultiStatus README (#2887)

* MultiStatus Readme Fix (#2889)

* Disable failing logrocket tests (#2890)

* Disable logrocket tests till they are fixed

* Disable another test

* [Klaviyo] Handle empty array being sent to Klaviyo resulting 400 Bad request. (#2885)

* Worked on fixing empty array being sent to Klaviyo

* Unit Test cases for removeProfile

---------

Co-authored-by: Gaurav Kochar <[email protected]>

* Add initial status to drip destination (#2884)

Co-authored-by: Jacob Meyer <[email protected]>

* Allow only dropdown value in objectType and toObjectType in UpsertCustomObjectRecord. (#2881)

* Disabled other enteries in obejctTYpe and toObjectType expect dropdown value

* .

---------

Co-authored-by: Gaurav Kochar <[email protected]>

* [HubSpot] Fix data type validations (#2866)

Co-authored-by: Gaurav Kochar <[email protected]>

* [STRAT-5634] | Multistatus Support on Google Enhanced Conversions. (#2853)

* Worked on implementing multistatus support on google enhanced conversions

* Made external audience Id mandatory

* Removed hardcoded token

* Handle externalAudienceId

* Commenting , just typo fix

---------

Co-authored-by: Gaurav Kochar <[email protected]>

* Update Rokt-Audiences Destination to support emailsha256 values (#2851)

* build: updates

* fix: run yarn types

* fix: build errors

* Postscript Events for Entered/Exit Segment Audience (#2842)

* Add events for entered and exited audience

* Add nock for events for tests

* [eventbridge] support for multi-status response (#2859)

* support for multi-status response

* changed title of action Send to SendV2

* added feature flag code check

* [Podscribe] New hashed_email property field (#2819)

* Add library field to Podscribe destination

* Handle case when payload.library is undefined

* Remove format validation from email field

* Update test snapshots

* Add library field to Podscribe destination

* Handle case when payload.library is undefined

* Update test snapshots

* feat(podscribe) add hashed_email properties field and user_id settings field

* fix(sergment) add hashed email

* fix(podscribe) clean up

* fix(podscribe) update test snapshot

* fix(podscribe) re-generate types

* Publish (#2892)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* STRATCONN-5564 - add sales objects (#2888)

* added sales type objects to SUPPORTED_HUBSPOT_OBJECT_TYPES

* added product

* removed quotes and leads

* add hubspot objects (#2898)

* adding new regions for Braze (#2896)

* Add User-Agent header to Drip destination for source identification (#2897)

* small updates to the default mappings in the Reddit CAPI integration (#2893)

Co-authored-by: Austin Hsueh <[email protected]>

* [Smart Hashing] [Liveramp Audiences] Cleanup (#2883)

* cleanup for smart hashing

* Update fb test to use processHashing.

* Use processHashing instead of old hashing util

* [STRATCONN-5489] - Add batch_keys to Klaviyo actions (#2880)

* [STRATCONN-5489] - Add batch_keys to Klaviyo actions

* Fix build

* UpsertProfile - add override_list_id to batch keys

* Add stats to measure grouping

* handle undefined statsclient

* Fix tests

* Add snapshot tests for batch keys

* Remove unused stat

* [STRATCONN-5657] - Add batch keys to webhook action destination (#2878)

* [STRATCONN-5657] - Add batch keys to webhook action destination

* Add stats

* Use histogram

* Add test for batch keys

* Supporting Group event in Userpilot cloud destination (#2838)

* Loops destination: ability to sync contact properties when sending events (#2792)

* Added contact properties to Send event action

* Type for contactProperties

* Type for full payload

* Update generated-types.ts

* feat: vendorId in purchase (#2766)

* Publish (#2900)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Smart Hashing] Add smart hashing documentation in readme (#2860)

* Add smart hashing documentation in readme

* Update smart hashing documentation

* update heading

* update docs

* Update smart hashing documentation

* [Smart Hashing] Add eslint rule to limit usage of createHash from crypto module (#2861)

* Add eslint rule to limit usage of createHash from crypto module

* Update error message

* [Smart Hashing] Cleanup (#2876)

* cleanup for smart hashing

* cleanup for smart hashing

* [Smart Hashing] Cleanup (#2877)

* cleanup for smart hashing

* Remove createHash from test file

* [Smart Hashing] Cleanup (#2879)

* cleanup for smart hashing

* Update reddit conversions test case

* Publish (#2901)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* STRATCONN-5564: add quotes object support (#2910)

* Update subscription presets and action descriptions for audience destinations for Journeys V2 (#2894)

* Update subscription presets and action descriptions

* Update the sync destination's description

* Change 'Journeys Step Transition Track' to 'Journeys Step Entered'

* added cleaning and hashing function and updated tests

* update cleanPhoneNumber for optional phoneNumber

---------

Co-authored-by: Austin Hsueh <[email protected]>
Co-authored-by: Joe Ayoub <[email protected]>
Co-authored-by: rvadera12 <[email protected]>
Co-authored-by: Nick Aguilar <[email protected]>
Co-authored-by: Varadarajan V <[email protected]>
Co-authored-by: Arijit Ray <[email protected]>
Co-authored-by: Innovative-GauravKochar <[email protected]>
Co-authored-by: Gaurav Kochar <[email protected]>
Co-authored-by: Marc Dillar <[email protected]>
Co-authored-by: m.dillar <[email protected]>
Co-authored-by: Jessica <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mayur-pitale <[email protected]>
Co-authored-by: guillaumefontan <[email protected]>
Co-authored-by: Jeff Kayne <[email protected]>
Co-authored-by: Ankit Gupta <[email protected]>
Co-authored-by: harsh-joshi99 <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Drew Thompson <[email protected]>
Co-authored-by: Sayan Das <[email protected]>
Co-authored-by: maryamsharif <[email protected]>
Co-authored-by: victor-ru <[email protected]>
Co-authored-by: Jonathan Sudhakar <[email protected]>
Co-authored-by: Joe Ayoub <[email protected]>
Co-authored-by: Manuel Núñez <[email protected]>
Co-authored-by: Manuel Nuñez <[email protected]>
Co-authored-by: Stephen Webber <[email protected]>
Co-authored-by: Jacob Meyer <[email protected]>
Co-authored-by: Ben Goodman <[email protected]>
Co-authored-by: James Bathgate <[email protected]>
Co-authored-by: pitronalldak <[email protected]>
Co-authored-by: monutwilio <[email protected]>
Co-authored-by: Arjun Bhandage <[email protected]>
Co-authored-by: Jacob Meyer <[email protected]>
Co-authored-by: ThabetIbrahim <[email protected]>
Co-authored-by: Dan <[email protected]>
Co-authored-by: Felipe Rivera Cienfuegos <[email protected]>
Co-authored-by: Miguel Pavon Diaz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varadarajan-tw varadarajan-tw varadarajan-tw approved these changes

Assignees
No one assigned
Labels
mode:cloud not-partner-eng-review (cloud) team:segment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsh-joshi99 @varadarajan-tw @joe-ayoub-segment