Skip to content

[Attentive] - new Ecommerce Action for Attentive #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joe-ayoub-segment
Copy link
Contributor

WIP

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment joe-ayoub-segment changed the title [Attentive] = new Ecommerce Action for Attentive [Attentive] - new Ecommerce Action for Attentive May 15, 2025
Copy link
Contributor

github-actions bot commented May 15, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Attentive, Action Field(s):userIdentifiers,eventType,items
  • Destination: Attentive, Action Field(s):userIdentifiers
  • Destination: Attentive, Action Field(s):userIdentifiers,subscriptionType
  • Destination: Recombee, Action Field(s):userIdentifiers,eventType,items
  • Destination: Recombee, Action Field(s):userIdentifiers
  • Destination: Recombee, Action Field(s):userIdentifiers,subscriptionType

Add these new fields as optional instead and assume default values in perform or performBatch block.

@joe-ayoub-segment
Copy link
Contributor Author

FYI @duynguyen100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant