Skip to content

[Podscribe] Send full property object to destination #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2025

Conversation

pitronalldak
Copy link
Contributor

Hi Segment Team,

Scope of this pull request:

Send all fields from the property to the destination.
Some of our customers are willing to send us custom fields, so we want to make the properties more generic.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment joe-ayoub-segment self-assigned this May 22, 2025
@joe-ayoub-segment joe-ayoub-segment merged commit 2a62f19 into segmentio:main May 28, 2025
11 of 12 checks passed
@joe-ayoub-segment
Copy link
Contributor

Hi @pitronalldak PR deployed. Please confirm that you are happy with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants