Skip to content

[Ortto] - allow additional in traits field #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joe-ayoub-segment
Copy link
Contributor

Need to allow additional fields in the traits field.

Testing

Not needed - in Private Beta

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (0451a3d) to head (83760ca).

Files with missing lines Patch % Lines
...ions/src/destinations/ortto/trackActivity/index.ts 50.00% 1 Missing ⚠️
...c/destinations/ortto/upsertContactProfile/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2938   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files        1064     1064           
  Lines       19612    19612           
  Branches     3767     3762    -5     
=======================================
  Hits        15313    15313           
  Misses       3015     3015           
  Partials     1284     1284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@xitonix xitonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @joe-ayoub-segment. Much appreciated. I also have some small cleanups which I will put in a new PR on Monday. Thanks again mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants