Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add db sync test case for test_ts_col_drop test_ts_col_alter_type test_ts_col_order_by #228

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

add db sync test case for test_ts_col_drop test_ts_col_alter_type test_ts_col_order_by #228

wants to merge 1 commit into from

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat force-pushed the add_ds_test branch 3 times, most recently from d22c757 to ea912d2 Compare November 12, 2024 08:08
dataroaring
dataroaring approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w41ter
Copy link
Contributor

w41ter commented Nov 13, 2024

Please place cases in separate directories, so that we can run those cases in parallel. @wyxxxcat

@wyxxxcat wyxxxcat requested a review from w41ter November 13, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyxxxcat @w41ter @dataroaring