add details for Brazil, British Indian Ocean Territory, Brunei, Bulga… #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ria and Burkina Faso
| Assert.Equal(existingCountryId, country.Id); | ||
| Assert.Equal(BRITISH_INDIAN_OCEAN_TERRITORY_NAME, country.Name); | ||
| Assert.NotNull(country.States); | ||
| Assert.Equal(BRITISH_INDIAN_OCEAN_TERRITORY_STATE_COUNT, country.States.Count()); |
Owner
There was a problem hiding this comment.
can we fix this warning
Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead
| private const string BULGARIA_ISO2_CODE = "BG"; | ||
| private const string BULGARIA_ISO3_CODE = "BGR"; | ||
| private const string BULGARIA_CALLING_CODE = "+359"; | ||
|
|
| private const string BURKINA_FASO_ISO3_CODE = "BFA"; | ||
| private const string BURKINA_FASO_CALLING_CODE = "+226"; | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
every other thing looks good, nice work Reagan
|
|
||
|
|
||
| [Fact] | ||
| public void Brazil_HasExpectedInformation() |
Owner
There was a problem hiding this comment.
Can we stick with GetCountry_ReturnsCorrectInformation_for_Brazil naming convention please
selfmadecode
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ria and Burkina Faso