add country details for France, FrenchGuiana and FrenchPolynesia #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanology
reviewed
Apr 22, 2025
| private const string FRANCE_ISO2_CODE = "FR"; | ||
| private const string FRANCE_ISO3_CODE = "FRA"; | ||
| private readonly string[] FRANCE_CALLING_CODE = ["+33"]; | ||
|
|
Collaborator
There was a problem hiding this comment.
No test for valid state type(s)
| private const string FRENCH_GUIANA_ISO2_CODE = "GF"; | ||
| private const string FRENCH_GUIANA_ISO3_CODE = "GUF"; | ||
| private readonly string[] FRENCH_GUIANA_CALLING_CODE = ["+594"]; | ||
|
|
Collaborator
There was a problem hiding this comment.
No test for valid state type(s)
Collaborator
Author
There was a problem hiding this comment.
the country has no states
| private const string FRENCH_POLYNESIA_ISO2_CODE = "PF"; | ||
| private const string FRENCH_POLYNESIA_ISO3_CODE = "PYF"; | ||
| private readonly string[] FRENCH_POLYNESIA_CALLING_CODE = ["+689"]; | ||
|
|
Collaborator
There was a problem hiding this comment.
No test for valid state type(s)
| new("Vosges", "FR-88", "metropolitan department"), | ||
| new("Yonne", "FR-89", "metropolitan department"), | ||
| new("Yvelines", "FR-78", "metropolitan department") | ||
| ]; |
Collaborator
There was a problem hiding this comment.
can we cross check this list again
deanology
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.