Skip to content

Predict pls v2 #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Predict pls v2 #361

wants to merge 17 commits into from

Conversation

NicholasDanks
Copy link
Collaborator

Creating a Pull Request to evaluate what needs to be implemented from this branch.

Nicholas Danks added 3 commits September 29, 2022 13:46
…the predict_lm_matrices() function considers if you are conducting DA or EA predictions and then selects the relevant indicators so that the LM predictions are only generated with the same information as the PLS predictions
@NicholasDanks NicholasDanks requested a review from soumyaray as a code owner May 21, 2025 12:01
@NicholasDanks
Copy link
Collaborator Author

NicholasDanks commented May 21, 2025

@soumyaray. You are absolutely correct this has already addressed the predict pls issue I mentioned.
Specifically, it ensures parity between LM and PLS when comparing predictions for earliest_antecedents and direct_antecedents methods. Ensuring that the LM never has more indicators available than the PLS model.

NicholasDanks and others added 14 commits May 27, 2025 11:38
Merge branch 'predict_pls_v2' of github.com:sem-in-r/seminr into predict_pls_v2

# Conflicts:
#	DESCRIPTION
#	R/import_lavaan_syntax.R
#	man/csem2seminr.Rd
…n as well. No change to estimation, just reporting. passess all tests and R CMD Check. 4 Notes
… a matrix (endogenous_items) fails. The fix casts the matrix to a vector when subsetting the data. (#349)
Merge branch 'predict_pls_v2' of github.com:sem-in-r/seminr into predict_pls_v2

# Conflicts:
#	R/feature_plspredict.R
…for checking the sm and mm for common wetware issues. This commit also makes the package pass R CMD Check and
…for checking the sm and mm for common wetware issues. This commit also makes the package pass R CMD Check and
…ified NULL for all of cores, reps and NoFolds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants