-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add vX.X and latest-variant Docker tags for minor version tracking #3423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2-16-stable
Are you sure you want to change the base?
Conversation
…flow Co-authored-by: fiftin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/release.yml
Outdated
| tags: | | ||
| type=raw,value=${{ github.ref_name }} | ||
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing release job used type=raw,value=${{ github.ref_name }} which emitted Docker tags like v2.10.3. The new configuration switches to type=semver,pattern={{version}} (and the same pattern in the other metadata steps) without adding prefix=v. docker/metadata-action strips the leading v from semver versions, so a release tagged v2.10.3 will now publish images 2.10.3 and 2.10 instead of v2.10.3/v2.10. This silently drops the tags that existing deployments pin to (semaphoreui/semaphore:vX.Y.Z), so pulls will fail once the change ships. Add prefix=v (or switch back to {{raw}}) to preserve the current tag names, and apply the same fix to the variant metadata blocks.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
- Added
prefix=vto every semver-based Docker metadata tag so both base and variant images continue publishing their existing v-prefixed tag names. .github/workflows/release.ymlL84-L245
Testing
⚠️ Tests not run (not requested)
Adds minor version tags (
vX.X) and variant-suffixed latest tags (latest-ansible2.16.5,latest-powershell7.5.0) to enable flexible version pinning in production deployments.Changes
type=semver,pattern={{major}}.{{minor}}to generatev2.10tags that track latest patch releasesflavor: latest=truewith suffixes to generatelatest-ansible2.16.5andlatest-powershell7.5.0v2.10-ansible2.16.5andv2.10-powershell7.5.0Applied consistently to both
semaphoreui/semaphoreandsemaphoreui/runnerimages.Tag Output Example
For release
v2.10.3:All existing tags preserved. Total: 18 tags per release (previously 6).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Note
Introduce semver-based tags (vX.X, vX.X.X) and variant-suffixed latest tags for server and runner images, adding Ansible/PowerShell metadata steps and wiring builds to their outputs.
.github/workflows/release.yml)raw ref_nameto semver (v{{version}},v{{major}}.{{minor}}).-ansible2.16.5) and PowerShell (-powershell7.5.0).latesttags, includinglatest-ansible2.16.5andlatest-powershell7.5.0viaflavorwith suffix.serverandrunnervariant images (server_ansible,server_powershell,runner_ansible,runner_powershell).labelsandtags.Written by Cursor Bugbot for commit 27b9cc8. This will update automatically on new commits. Configure here.