New Rules Proposal: Detect exposure to log injection in java. #3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This rule, for java language, is intended to detect and raise a warning when an unsanitized String method parameter is used as an argument to a logger call. The goal is to allow to detect such situation and perform a manual control that a validation is in place.
💡 To limit the false positives, I updated the rule to only trigger for methods that are exposed as a "web service". I added annotations used by Spring Web, JAX-RS and JAX-WS frameworks.
I tested the rule against the sample code using the online rule editor:
Thank you very much for your feedback 😉