Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sass dependency #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove sass dependency #77

wants to merge 1 commit into from

Conversation

mdh
Copy link

@mdh mdh commented Sep 1, 2022

pdfjs_viewer-rails depends on sassc-rails, which hasnt been updated in 3 years. See https://github.com/sass/sassc-rails

sassc-rails in turn depends on sassc which is deprecated, see https://github.com/sass/sassc#sassc :

Warning: LibSass and SassC are deprecated. While it will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

As there is very little css in this gem, why not get rid of dependency and just use plain css and allow people to use current sass implementations?

@mdh mdh mentioned this pull request Sep 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdh