Repository navigation
release: 0.54.0 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release: 0.54.0 #80
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "0.53.0" | ||
| ".": "0.54.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details. | ||
|
|
||
| __title__ = "sent_dm" | ||
| __version__ = "0.53.0" # x-release-please-version | ||
| __version__ = "0.54.0" # x-release-please-version |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Users upgrading to 0.54.0 lose public names like
MeRetrieveResponsewith no alias and no migration note in the release notes. The breaking-changes line only names the topic, not what was renamed or what to do. CLAUDE.md says "A rename or a removal keeps an alias" and changelog lines must say "what changed, and what to do about it". Fix: before publishing, restore aliases for the removed names through the SDK configuration. Failing that, edit the release notes in the release PR body to map each old name to its replacement.Why this was flagged
Merging this release PR publishes 0.54.0 to PyPI with the changes from base commit 1be25d7. That commit removed exported names from src/sent_dm/types/init.py with no aliases. The removed names include MeRetrieveResponse, UserListResponse, ProfileListResponse, NumberLookupResponse, WebhookRotateSecretResponse, MessageRetrieveStatusResponse and MessageRetrieveActivitiesResponse; for example, me_retrieve_response.py was renamed to account.py. A grep of src/ and api.md finds no remaining definition or alias for these names. Code that runs
from sent_dm.types import MeRetrieveResponseworks on 0.53.0 and raises ImportError on 0.54.0. The new CHANGELOG.md:8 entry is the only guidance customers get, and it lists neither the removed names nor their replacements. The version bump from 0.53.0 to 0.54.0 is only a minor bump, so a~=0.53or^0.53-style pin can pick up the break without warning.Verification: The trigger is a user upgrading from 0.53.0 to 0.54.0 whose code imports any of the removed names. Base commit 1be25d7 drops exports such as
MeRetrieveResponsefrom src/sent_dm/types/init.py with no alias, sofrom sent_dm.types import MeRetrieveResponseraises ImportError. The changelog line at CHANGELOG.md:8 does not say which names changed or what to replace them with.