Add LST Backward Average script #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmberMulder
changed the title
|
@jonasViehweger Can you please review? |
planetary-variables/land-surface-temperature/land-surface-temperature-backward-average/raw.js
Show resolved
Hide resolved
| const date = "2022-12-31"; // The date for which the backward average is calculated | ||
| const nDays = 20; // The number of days to load data for | ||
| const scaleFactor = 100; // The scale factor for the SWC values | ||
| const defaultVis = true; // If true, the default visualization will be applied. If false, the color_min and color_max values will be used. |
There was a problem hiding this comment.
Here it's the same as for SWC, we can now set the min/max directly in the ColorRamp, so no need to do it ourselves.
Suggested change
| const defaultVis = true; // If true, the default visualization will be applied. If false, the color_min and color_max values will be used. |
There was a problem hiding this comment.
Initially I did not add this to be able to have a defaultVis just like the other LST custom script examples. But I agree it would be better to immediately include the update in the ColorRampVisualizer initialization. Therefore, I have updated it.
Comment on lines
82
to
94
| function updateCMap(min, max) { | ||
| const numIntervals = cmap.length; | ||
| const intervalLength = (max - min) / (numIntervals - 1); | ||
| for (let i = 0; i < numIntervals; i++) { | ||
| cmap[i][0] = min + intervalLength * i; | ||
| } | ||
| } | ||
|
|
||
| // Update the min max of color bar if defaultVis set to false | ||
| if (!defaultVis) updateCMap(color_min, color_max); | ||
|
|
||
| // Initialize the ColorRamp | ||
| const visualizer = new ColorRampVisualizer(cmap); |
There was a problem hiding this comment.
Suggested change
| function updateCMap(min, max) { | |
| const numIntervals = cmap.length; | |
| const intervalLength = (max - min) / (numIntervals - 1); | |
| for (let i = 0; i < numIntervals; i++) { | |
| cmap[i][0] = min + intervalLength * i; | |
| } | |
| } | |
| // Update the min max of color bar if defaultVis set to false | |
| if (!defaultVis) updateCMap(color_min, color_max); | |
| // Initialize the ColorRamp | |
| const visualizer = new ColorRampVisualizer(cmap); | |
| // Initialize the ColorRamp | |
| const visualizer = new ColorRampVisualizer(cmap, color_min, color_max); |
There was a problem hiding this comment.
See comment above. Updated.
|
@jonasViehweger Thanks for the review, I have added the changes! |
charliemoriarty
pushed a commit
to charliemoriarty/custom-scripts
that referenced
this pull request
Nov 7, 2024
* Initial setup LST Backwar Average scripts and docs * Create and update color ramp in one command --------- Co-authored-by: Amber Mulder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation and evalscripts on computation of Land Surface Temperature Backward Average.