Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eo-crops #1

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

add eo-crops #1

wants to merge 23 commits into from

Conversation

j-desloires
Copy link

@j-desloires j-desloires commented Feb 3, 2022

Hi Sinergise team,

I made a small git repository using eo-learn to download and preprocess Sentinel and VHRS data (PlanetScope, Spot and Pleaides). I think it may interest some people, especially for crop monitoring.

I would like to thank ESA NoR program for the free Sentinel hub account.

Cheers,
Johann

@batic
Copy link
Contributor

batic commented Feb 3, 2022

Hi @j-desloires

That's great! Could I ask you to properly add eo-crops to the pull request (folder?), not just the link?

Best,
Matej

@j-desloires

This comment was marked as resolved.

@j-desloires j-desloires closed this Feb 7, 2022
@batic
Copy link
Contributor

batic commented Feb 7, 2022

Hi @j-desloires

Any particular reason for closing the pull request? Is there something we can help with?

Matej

@j-desloires
Copy link
Author

j-desloires commented Feb 7, 2022

HI @batic,

Thanks for your comment.

The repo just lacks some unit testing and to handle temporary files more efficiently, but I can do it within 2/3 weeks..!

I would be very happy to have your feedback, this is my first pull request and this is an opportunity to improve my python best practices.

Have a great day,
Johann

@j-desloires j-desloires reopened this Feb 7, 2022
@batic
Copy link
Contributor

batic commented Feb 7, 2022

Great!

In the mean time, we'll have a look and give you some feedback. We plan to update (at least some) of the examples in the repository as well, so I'll add your PR to the "todo" list :)

Don't hesitate to reach out on forum as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants