Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOExecutor improvements, part 3 #360

Merged
merged 11 commits into from
Jan 18, 2022
Merged

Conversation

AleksMat
Copy link
Contributor

Implements various improvements in EOExecutor class and especially in the generated report. Changes are documented in commit messages.

@AleksMat AleksMat requested a review from zigaLuksic January 17, 2022 15:30
Copy link
Collaborator

@zigaLuksic zigaLuksic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying the handler generator around makes the code a bit less readable, but I see no better way

@codecov-commenter
Copy link

Codecov Report

Merging #360 (877d846) into develop-v1.0 (306b0da) will increase coverage by 0.10%.
The diff coverage is 92.37%.

Impacted file tree graph

@@               Coverage Diff                @@
##           develop-v1.0     #360      +/-   ##
================================================
+ Coverage         82.88%   82.99%   +0.10%     
================================================
  Files                53       53              
  Lines              5365     5422      +57     
================================================
+ Hits               4447     4500      +53     
- Misses              918      922       +4     
Impacted Files Coverage Δ
core/eolearn/core/extra/ray.py 89.28% <75.00%> (ø)
.../eolearn/visualization/eoexecutor_visualization.py 88.13% <84.61%> (-0.04%) ⬇️
core/eolearn/core/eoexecution.py 93.15% <96.61%> (+0.17%) ⬆️
core/eolearn/core/eonode.py 94.23% <100.00%> (ø)
core/eolearn/core/fs_utils.py 96.42% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306b0da...877d846. Read the comment docs.

@AleksMat AleksMat merged commit a83d837 into develop-v1.0 Jan 18, 2022
@AleksMat AleksMat deleted the feat/eoexecutor-improvements3 branch January 18, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants