Skip to content

feat(worker): use lightweight liveness & add Celery readiness probe #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+31 −3
Open

feat(worker): use lightweight liveness & add Celery readiness probe #1923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c947b0
feat(sentry): use lightweight liveness & add Celery readiness probe f…
Nov 5, 2025
dd0a256
fix: missing condition end
Nov 5, 2025
12d936c
refactor: remove default key
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/sentry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,15 @@ Note: this table is incomplete, so have a look at the values.yaml in case you mi
| sentry.worker.existingSecretEnv | string | `""` | |
| sentry.worker.livenessProbe.enabled | bool | `true` | |
| sentry.worker.livenessProbe.failureThreshold | int | `3` | |
| ssentry.worker.livenessProbe.initialDelaySeconds | int | `10` | |
| sentry.worker.livenessProbe.periodSeconds | int | `60` | |
| sentry.worker.livenessProbe.timeoutSeconds | int | `10` | |
| sentry.worker.readinessProbe.enabled | bool | `true` | |
| sentry.worker.readinessProbe.failureThreshold | int | `3` | |
| ssentry.worker.readinessProbe.initialDelaySeconds | int | `10` | |
| sentry.worker.readinessProbe.periodSeconds | int | `60` | |
| sentry.worker.readinessProbe.timeoutSeconds | int | `10` | |
| sentry.worker.readinessProbe.celeryTimeoutSeconds | int | `5` | |
| sentry.worker.nodeSelector | object | `{}` | |
| sentry.worker.replicas | int | `1` | |
| sentry.worker.resources | object | `{}` | |
Expand Down
18 changes: 15 additions & 3 deletions charts/sentry/templates/sentry/worker/deployment-sentry-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,18 +132,30 @@ spec:
{{- if .Values.sentry.worker.volumeMounts }}
{{ toYaml .Values.sentry.worker.volumeMounts | indent 8 }}
{{- end }}
{{- if .Values.sentry.worker.livenessProbe.enabled }}
{{- if .Values.sentry.worker.livenessProbe.enabled }}
livenessProbe:
periodSeconds: {{ .Values.sentry.worker.livenessProbe.periodSeconds }}
initialDelaySeconds: 10
initialDelaySeconds: {{ .Values.sentry.worker.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.sentry.worker.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.sentry.worker.livenessProbe.failureThreshold }}
exec:
command:
- rm
- -f
- /tmp/health.txt
{{- end }}
{{- if .Values.sentry.worker.readinessProbe.enabled }}
readinessProbe:
periodSeconds: {{ .Values.sentry.worker.readinessProbe.periodSeconds }}
initialDelaySeconds: {{ .Values.sentry.worker.readinessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.sentry.worker.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.sentry.worker.readinessProbe.failureThreshold }}
exec:
command:
- sentry
- exec
- -c
- 'from sentry.celery import app; import os; dest="celery@{}".format(os.environ["HOSTNAME"]); print(app.control.ping(destination=[dest], timeout=5)[0][dest]["ok"])'
- 'from sentry.celery import app; import os; dest="celery@{}".format(os.environ["HOSTNAME"]); print(app.control.ping(destination=[dest], timeout={{ .Values.sentry.worker.readinessProbe.celeryTimeoutSeconds }})[0][dest]["ok"])'
{{- end }}
resources:
{{ toYaml .Values.sentry.worker.resources | indent 12 }}
Expand Down
9 changes: 9 additions & 0 deletions charts/sentry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,17 @@ sentry:
livenessProbe:
enabled: true
periodSeconds: 60
initialDelaySeconds: 10
timeoutSeconds: 10
failureThreshold: 3
readinessProbe:
enabled: true
periodSeconds: 60
initialDelaySeconds: 10
timeoutSeconds: 10
failureThreshold: 3
# time to wait for celery to respond
celeryTimeoutSeconds: 5
sidecars: []
# securityContext: {}
# containerSecurityContext: {}
Expand Down