Skip to content
This repository was archived by the owner on May 25, 2020. It is now read-only.

fix: don't double escape special characters in title#795

Open
inyono wants to merge 3 commits intomasterfrom
feature/input-filter
Open

fix: don't double escape special characters in title#795
inyono wants to merge 3 commits intomasterfrom
feature/input-filter

Conversation

@inyono
Copy link
Contributor

@inyono inyono commented Nov 13, 2018

Changelog

Fixed

  • Don't double escape special characters (e.g. <, *) in entities' title (#795)

@inyono inyono requested a review from Knorrke November 13, 2018 16:29
…re/input-filter

# Conflicts:
#	src/module/Ui/templates/entity/page/applet.twig
#	src/module/Ui/templates/entity/page/article.twig
#	src/module/Ui/templates/entity/page/course-page.twig
#	src/module/Ui/templates/entity/page/course.twig
#	src/module/Ui/templates/taxonomy/term/entity/article.twig
@Knorrke
Copy link
Member

Knorrke commented Nov 13, 2018

Can you check the notification and event templates again? I couldn't create the notifications locally, but at least I could inject a <script> in the reasoning when accepting/rejecting a revision... This script was then executed e.g. in /event/history and also in the user profile (and probably also in a notification?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants