Add a FontFace::variations method for returning axis values
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new API will be used by Servo to properly retrieve all axis variation values after creating the `FontFace.` Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Aug 21, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Signed-off-by: Martin Robinson <[email protected]>
jdm
approved these changes
Aug 22, 2025
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Aug 22, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Aug 22, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Aug 22, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Aug 22, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Testing: We currently don't have tests for Windows, but variation support is covered by the WPT tests. Fixes: This is part of #38800. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Aug 22, 2025
Unlike other platforms where we read the default axis values and combine it with variations from style to make the font face, we set the variations from the style when creating the font face and then read the final variations from the face. It seems that DirectWrite does the normalization of variation values internally. This depends on servo/dwrote-rs#68. Testing: We currently don't have tests for Windows, but variation support is covered by the WPT tests. Fixes: This is part of #38800. Signed-off-by: Martin Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API will be used by Servo to properly retrieve all axis
variation values after creating the
FontFace.Signed-off-by: Martin Robinson [email protected]