Check if policy name adheres to spec grammar #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
force-pushed
the
fix-checking-of-policy-name
branch
2 times, most recently
from
bcb9c8c to
1aa3fce
Compare
jdm
approved these changes
Aug 26, 2025
src/lib.rs
Outdated
| actually uses is the global's CSP List. So this function operates on that. | ||
| */ | ||
| pub fn is_trusted_type_policy_creation_allowed(&self, policy_name: String, created_policy_names: Vec<String>) -> (CheckResult, Vec<Violation>) { | ||
| pub fn is_trusted_type_policy_creation_allowed(&self, policy_name: &str, created_policy_names: Vec<&str>) -> (CheckResult, Vec<Violation>) { |
There was a problem hiding this comment.
nit: this could be &[&str] instead of a Vec.
There was a problem hiding this comment.
Fixed. Had to wrangle a bit on the Servo side, but I think I was able to make things work: https://github.com/servo/servo/pull/38886/files#diff-b3e53a3314875c9fede32bfb6ea2ac4b1b5a345ab9f3becc32348ecae11f29f7
TimvdLippe
force-pushed
the
fix-checking-of-policy-name
branch
from
1aa3fce to
d01e8cc
Compare
Before we were accepting any policy name. However, there is a grammar that specifies which characters are valid. Signed-off-by: Tim van der Lippe <[email protected]>
TimvdLippe
force-pushed
the
fix-checking-of-policy-name
branch
from
d01e8cc to
f8143ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were accepting any policy name. However, there is a grammar that specifies which characters are valid.