Add support for ::slider-fill,::slider-track, and ::slider-thumb pseudo-elements#310
Add support for ::slider-fill,::slider-track, and ::slider-thumb pseudo-elements#310mrobinson merged 3 commits intoservo:mainfrom
::slider-fill,::slider-track, and ::slider-thumb pseudo-elements#310Conversation
|
I force-pushed main during an upgrade, can you rebase your changes? |
Ok, rebase done. Please help review @Loirooriol |
|
@yisibl These are resolved but not added to the spec text yet, so there's nothing we can implement for at this time. For this PR we are only going to support |
|
I have rebased this. |
|
@xiaochengh Thank you for your reply. I got it. |
mrobinson
changed the title
<input type=range>
mrobinson
changed the title
<input type=range>::slider-fill,::slider-track, and ::slider-thumb pseudo-elements
mrobinson
changed the title
::slider-fill,::slider-track, and ::slider-thumb pseudo-elements::slider-fill,::slider-track, and ::slider-thumb pseudo-elements
|
Shouldn't these use the names from the CSS WG resolution: |
|
I'm also really not sure about exposing unspecified pseudo-elements to authors here. I think we should probably expose |
They are only parsed if |
|
I believe for now we are just following the current draft spec, |
Signed-off-by: Tin Tun Aung <tin.tun.aung1@huawei.com>
Signed-off-by: Budiman Arbenta <arbenta6@gmail.com>
Signed-off-by: Budiman Arbenta <arbenta6@gmail.com>
Implement the layout of `<input type="range">`. Support automatically calculating the position of thumb based on the current input value, and the size of range-track and range-thumb. Added a document.has_script_or_layout_blocker function to detect whether it is possible to run box_area_query during bind_to_tree, add delay_task if there are blocker. Here are some of the fixes made in this PR: 1. Fixed the structure for input type range's pseudo elements. 2. Fixed the positioning of input type range's thumb based on current value, width, and direction. 3. Allow input type range to stretch vertically in a bigger container. Original PR: #41024 Stylo PR: servo/stylo#310 Testing: Some improvements in WPT tests, with a few regressions. This change includes a Servo-specific appearance test to detect unexpected changes to the look and feel of range widgets. Fixes: #22728 --------- Signed-off-by: Budiman Arbenta <arbenta6@gmail.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: rayguo17 <tin.tun.aung1@huawei.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Implement the layout of `<input type="range">`. Support automatically calculating the position of thumb based on the current input value, and the size of range-track and range-thumb. Added a document.has_script_or_layout_blocker function to detect whether it is possible to run box_area_query during bind_to_tree, add delay_task if there are blocker. Here are some of the fixes made in this PR: 1. Fixed the structure for input type range's pseudo elements. 2. Fixed the positioning of input type range's thumb based on current value, width, and direction. 3. Allow input type range to stretch vertically in a bigger container. Original PR: #41024 Stylo PR: servo/stylo#310 Testing: Some improvements in WPT tests, with a few regressions. This change includes a Servo-specific appearance test to detect unexpected changes to the look and feel of range widgets. Fixes: #22728 --------- Signed-off-by: Budiman Arbenta <arbenta6@gmail.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: rayguo17 <tin.tun.aung1@huawei.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
8 participants
Added
::slider-track,::slider-fill,::slider-thumbpseudo-elements to be used in Servo.Original PR: #276
Servo PR: servo/servo#41562