When animating a property, ignore any keyframes without that property#338
Open
simonwuelker wants to merge 1 commit intoservo:mainfrom
Open
When animating a property, ignore any keyframes without that property#338simonwuelker wants to merge 1 commit intoservo:mainfrom
simonwuelker wants to merge 1 commit intoservo:mainfrom
Conversation
simonwuelker
commented
Mar 19, 2026
Comment on lines
+267
to
+274
|
|
||
| #[derive(Clone, Debug, MallocSizeOf)] | ||
| enum AnimationValueOrReference { | ||
| /// This keyframe declares the property with the given value. | ||
| AnimationValue(AnimationValue), | ||
| /// This keyframe does not declare the property. | ||
| NotDefinedHere(PropertyDeclarationOffsets), | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Note that the size of AnimationValueOrReference is the same as that of AnimationValue.
In other words, this change doesn't cost us anything in terms of memory.
simonwuelker
force-pushed
the
keyframes-missing-properties-2
branch
from
bf64796 to
5cfe0f0
Compare
simonwuelker
force-pushed
the
keyframes-missing-properties-2
branch
from
5cfe0f0 to
dd8dc23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the purposes of animating a single keyframe, we should ignore any keyframes that don't declare that property.
The basic idea here is to store a list on each keyframe, with one entry for each animating property. The entry is either the value of the declared property (if any), or the indices of the adjacent keyframes which do declare the property.
That way we don't have to walk the list of keyframes within
get_property_declaration_at_timeat all.cc @mrobinson
Companion PR for servo/servo#43461