Added requirements-rocm.txt for AMD GPU and ROCm

[ChangLiu0709]

Motivation

Modifications

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
• Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
• For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
• Please feel free to join our Slack channel at https://sgl-fru7574.slack.com/archives/C09784E3EN6 to discuss your PR.

[gemini-code-assist]

Summary of Changes

Hello @ChangLiu0709, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new requirements-rocm.txt file, which is crucial for enabling the project to run seamlessly on systems equipped with AMD GPUs and the ROCm platform. By providing a distinct set of dependencies, it ensures that users can easily configure their environments with the correct PyTorch ROCm-specific packages, thereby broadening the project's hardware support and accessibility.

Highlights

• New Dependency File: A new file, requirements-rocm.txt, has been added to the project.
• AMD GPU and ROCm Support: This new file provides a dedicated set of dependencies specifically tailored for environments utilizing AMD GPUs with ROCm, enhancing hardware compatibility.
• PyTorch ROCm Integration: The requirements-rocm.txt specifies the PyTorch ROCm wheel index and includes version-locked PyTorch components (torch, torchaudio, torchvision) compatible with ROCm 6.3.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a requirements-rocm.txt file to add support for AMD GPUs with ROCm. The dependencies listed are mostly consistent with the existing requirements.txt. However, for better reproducibility, I've suggested pinning all dependency versions. A more significant issue is that the project's installation process does not seem to be updated to use this new file. To make this feature usable, the installation documentation (docs/get_started/install.md) should be updated to instruct users on how to install the ROCm-specific dependencies. Without this, users will not know how to leverage the ROCm support you've added.

[gemini-code-assist]

For better reproducibility of the environment, it's a good practice to pin the versions of all dependencies. Several packages in this file (pre-commit, datasets, setuptools, tqdm, wandb, psutil, numpy, accelerate, pydantic, openai-harmony) are currently not pinned to a specific version. This could lead to unexpected issues if a new version of a dependency with breaking changes is released. You can generate the versions for your current working environment using pip freeze and add them here.

[FrankLeeeee]

Hi @ChangLiu0709 , can you run pre-commit on the changed file?

[ChangLiu0709]

Hi @ChangLiu0709 , can you run pre-commit on the changed file?

Hi @FrankLeeeee I've run the pre-commit on the changed file now. To fix the warning, I have re-committed the changes to a new branch rocm-support and then merged to the main.