Add two scripts#119
Conversation
Summary of ChangesHello @DubhepPan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces two new shell scripts aimed at enhancing the automated testing capabilities for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds two test enumeration scripts. I've found a few issues, including a critical bug in enumerate_test_low_latency.sh where some test parameter loops are empty because the corresponding arrays are not defined, causing tests to be skipped silently. Both scripts also have issues with argument parsing, where they reference unhandled options and a non-existent show_help function. I've also included some suggestions for improving code consistency and safety.
* upstream/main: support long cat on a3 (sgl-project#182) Add two scripts (sgl-project#119) Add packages to release (sgl-project#204) [Test] Testing the generalization of fused moe (sgl-project#167)
* Create enumerate_test_intranode.sh * Create enumerate_test_low_latency.sh * Update enumerate_test_intranode.sh * Update enumerate_test_low_latency.sh * Update enumerate_test_intranode.sh * Update pr-test-npu.yml * Update pr-test-npu.yml * Update enumerate_test_low_latency.sh * Update enumerate_test_intranode.sh * Update pr-test-npu.yml * Update pr-test-npu.yml * Update pr-test-npu.yml * Update CMakeLists.txt * Update enumerate_test_intranode.sh * Update enumerate_test_low_latency.sh * Create daily-build-test.yml * Update pr-test-npu.yml * Update pr-test-npu.yml * Update CMakeLists.txt * Update pr-test-npu.yml * Update pr-test-npu.yml * Update daily-build-test.yml * Update daily-build-test.yml * Update daily-build-test.yml * Update enumerate_test_intranode.sh * Update daily-build-test.yml * Update enumerate_test_intranode.sh * Update daily-build-test.yml * Update daily-build-test.yml * Update daily-build-test.yml * Update and rename enumerate_test_intranode.sh to enumerate_test_intranode_part_one.sh * Create enumerate_test_intranode_part_two.sh * Update daily-build-test.yml * Update daily-build-test.yml * Update daily-build-test.yml * Update enumerate_test_intranode_part_two.sh * Update enumerate_test_intranode_part_two.sh * Update enumerate_test_intranode_part_one.sh * Update enumerate_test_intranode_part_one.sh * Update enumerate_test_intranode_part_one.sh * Update daily-build-test.yml * Update enumerate_test_intranode_part_one.sh * Delete scripts/enumerate_test_intranode_part_two.sh * Rename enumerate_test_intranode_part_one.sh to enumerate_test_intranode.sh * Update daily-build-test.yml * Update daily-build-test.yml * Update enumerate_test_low_latency.sh * Update daily-build-test.yml * Update daily-build-test.yml * Update daily-build-test.yml * Update pr-test-npu.yml * Update daily-build-test.yml * Update pr-test-npu.yml
Add two scripts for testing