Skip to content

Add two scripts#119

Merged
Yael-X merged 53 commits into
sgl-project:mainfrom
DubhepPan:main
Nov 26, 2025
Merged

Add two scripts#119
Yael-X merged 53 commits into
sgl-project:mainfrom
DubhepPan:main

Conversation

@DubhepPan
Copy link
Copy Markdown
Contributor

Add two scripts for testing

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @DubhepPan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces two new shell scripts aimed at enhancing the automated testing capabilities for the deep-ep package. These scripts facilitate the systematic execution of test_intranode.py and test_low_latency.py by enumerating various input parameters. This approach ensures a more comprehensive validation of the system under different configurations, while also automating the necessary build, installation, and environment setup steps.

Highlights

  • New Test Automation Scripts: Two new bash scripts, enumerate_test_intranode.sh and enumerate_test_low_latency.sh, have been added to automate the execution of specific Python test files.
  • Comprehensive Parameter Enumeration: These scripts are designed to run test_intranode.py and test_low_latency.py respectively, iterating through a wide range of parameter combinations to ensure thorough testing coverage.
  • Automated Build and Environment Setup: Each script includes functionality to conditionally build and install the deep-ep package, set the HCCL_BUFFSIZE environment variable, and source the Ascend toolkit environment, streamlining the testing workflow.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two test enumeration scripts. I've found a few issues, including a critical bug in enumerate_test_low_latency.sh where some test parameter loops are empty because the corresponding arrays are not defined, causing tests to be skipped silently. Both scripts also have issues with argument parsing, where they reference unhandled options and a non-existent show_help function. I've also included some suggestions for improving code consistency and safety.

Comment thread scripts/enumerate_test_low_latency.sh Outdated
Comment thread scripts/enumerate_test_intranode.sh Outdated
Comment thread scripts/enumerate_test_intranode.sh Outdated
Comment thread scripts/enumerate_test_low_latency.sh Outdated
Comment thread scripts/enumerate_test_low_latency.sh Outdated
Comment thread scripts/enumerate_test_intranode.sh Outdated
Comment thread scripts/enumerate_test_intranode.sh
Comment thread .github/workflows/pr-test-npu.yml Outdated
Comment thread .github/workflows/pr-test-npu.yml Outdated
Comment thread .github/workflows/daily-build-test.yml
@Yael-X Yael-X merged commit fe870cd into sgl-project:main Nov 26, 2025
7 checks passed
oagniqgnat added a commit to oagniqgnat/sgl-kernel-npu that referenced this pull request Dec 25, 2025
* upstream/main:
  support long cat on a3 (sgl-project#182)
  Add two scripts (sgl-project#119)
  Add packages to release (sgl-project#204)
  [Test] Testing the generalization of fused moe  (sgl-project#167)
AndyKong2020 pushed a commit to AndyKong2020/sgl-kernel-npu that referenced this pull request Mar 24, 2026
* Create enumerate_test_intranode.sh

* Create enumerate_test_low_latency.sh

* Update enumerate_test_intranode.sh

* Update enumerate_test_low_latency.sh

* Update enumerate_test_intranode.sh

* Update pr-test-npu.yml

* Update pr-test-npu.yml

* Update enumerate_test_low_latency.sh

* Update enumerate_test_intranode.sh

* Update pr-test-npu.yml

* Update pr-test-npu.yml

* Update pr-test-npu.yml

* Update CMakeLists.txt

* Update enumerate_test_intranode.sh

* Update enumerate_test_low_latency.sh

* Create daily-build-test.yml

* Update pr-test-npu.yml

* Update pr-test-npu.yml

* Update CMakeLists.txt

* Update pr-test-npu.yml

* Update pr-test-npu.yml

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update enumerate_test_intranode.sh

* Update daily-build-test.yml

* Update enumerate_test_intranode.sh

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update and rename enumerate_test_intranode.sh to enumerate_test_intranode_part_one.sh

* Create enumerate_test_intranode_part_two.sh

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update enumerate_test_intranode_part_two.sh

* Update enumerate_test_intranode_part_two.sh

* Update enumerate_test_intranode_part_one.sh

* Update enumerate_test_intranode_part_one.sh

* Update enumerate_test_intranode_part_one.sh

* Update daily-build-test.yml

* Update enumerate_test_intranode_part_one.sh

* Delete scripts/enumerate_test_intranode_part_two.sh

* Rename enumerate_test_intranode_part_one.sh to enumerate_test_intranode.sh

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update enumerate_test_low_latency.sh

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update daily-build-test.yml

* Update pr-test-npu.yml

* Update daily-build-test.yml

* Update pr-test-npu.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants