-
Notifications
You must be signed in to change notification settings - Fork 53
update readme.md for fused moe #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @goosj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's README files to include essential information regarding the usage and control of fused Mixture-of-Experts (MoE) with SGLang. The changes provide clear instructions on how to enable or disable this feature via an environment variable, improving user guidance and clarity for developers working with MoE adaptations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the English and Chinese README files to add instructions on how to enable and disable fused MoE using an environment variable. The changes are clear, but I've suggested a formatting improvement to wrap the shell commands in code blocks for better readability and to ensure they can be copied and pasted without issues.
| 1. Enable fused moe | ||
| export ENABLE_FUSED_MOE=1 | ||
| 2. Disable fused moe | ||
| export ENABLE_FUSED_MOE=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to make the commands easier to copy, it's a good practice to wrap shell commands in bash code blocks. This also helps visually separate the commands from the description.
Here is a suggested format:
1. Enable fused moe
```bash
export ENABLE_FUSED_MOE=1
```
2. Disable fused moe
```bash
export ENABLE_FUSED_MOE=0
```| 1.开启融合算子 | ||
| export ENABLE_FUSED_MOE=1 | ||
| 2.关闭融合算子 | ||
| export ENABLE_FUSED_MOE=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to make the commands easier to copy, it's a good practice to wrap shell commands in bash code blocks. Also, adding a space after the list number is a good practice for markdown formatting.
Here is a suggested format:
1. 开启融合算子
```bash
export ENABLE_FUSED_MOE=1
```
2. 关闭融合算子
```bash
export ENABLE_FUSED_MOE=0
```
update readme.md for fused moe