Skip to content

Conversation

@goosj
Copy link
Contributor

@goosj goosj commented Oct 31, 2025

update readme.md for fused moe

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @goosj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's README files to include essential information regarding the usage and control of fused Mixture-of-Experts (MoE) with SGLang. The changes provide clear instructions on how to enable or disable this feature via an environment variable, improving user guidance and clarity for developers working with MoE adaptations.

Highlights

  • Documentation Update: Added a new section to both the English and Chinese README files (README.md and README_CN.md) specifically for 'fused moe'.
  • Fused MoE Usage: The new documentation details how to enable and disable fused Mixture-of-Experts (MoE) functionality, specifically in the context of SGLang, using the ENABLE_FUSED_MOE environment variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the English and Chinese README files to add instructions on how to enable and disable fused MoE using an environment variable. The changes are clear, but I've suggested a formatting improvement to wrap the shell commands in code blocks for better readability and to ensure they can be copied and pasted without issues.

Comment on lines +64 to +67
1. Enable fused moe
export ENABLE_FUSED_MOE=1
2. Disable fused moe
export ENABLE_FUSED_MOE=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to make the commands easier to copy, it's a good practice to wrap shell commands in bash code blocks. This also helps visually separate the commands from the description.

Here is a suggested format:

1. Enable fused moe
   ```bash
   export ENABLE_FUSED_MOE=1
   ```
2. Disable fused moe
   ```bash
   export ENABLE_FUSED_MOE=0
   ```

Comment on lines +66 to +69
1.开启融合算子
export ENABLE_FUSED_MOE=1
2.关闭融合算子
export ENABLE_FUSED_MOE=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to make the commands easier to copy, it's a good practice to wrap shell commands in bash code blocks. Also, adding a space after the list number is a good practice for markdown formatting.

Here is a suggested format:

1. 开启融合算子
   ```bash
   export ENABLE_FUSED_MOE=1
   ```
2. 关闭融合算子
   ```bash
   export ENABLE_FUSED_MOE=0
   ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant