[Feat] Lightning indexer op & GE helper engineering #203
+4,418
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
randgun
commented
Nov 24, 2025
| bool curActSeqLenIsZero = false; | ||
| bool needDealActS1LessThanS1 = false; // S1的实际长度小于shape的S1长度时，是否需要清理输出 | ||
| uint32_t actMBaseSize = 0U; // m轴(gS1)方向实际大小 | ||
| uint32_t mBasicSizeTail = 0U; // gS1方向循环的尾基本块大小 |
Contributor
Author
There was a problem hiding this comment.
Need to translate Chinese code comment to English
randgun
force-pushed
the
br_indexer
branch
3 times, most recently
from
24c5522 to
65ec442
Compare
Contributor
Author
|
/gemini check |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
| @@ -1,5 +1,6 @@ | |||
| # set the library output dir to the python dir for wheel package build | |||
| set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_SOURCE_DIR}/python/sgl_kernel_npu/sgl_kernel_npu/lib) | |||
| set(ASCEND_INCLUDE_DIR ${ASCEND_HOME_PATH}/aarch64-linux/include) | |||
Collaborator
There was a problem hiding this comment.
pass env or option to replace ${ASCEND_HOME_PATH}/aarch64-linux/include
| at::TensorOptions().dtype(at::kByte).device(query.options().device())); | ||
|
|
||
| if (actualCaptureNum >= MAX_CAPTURE_NUM) { | ||
| static auto preillTilingBuffer = |
Collaborator
There was a problem hiding this comment.
preillTilingBuffer => prefill
It is uncached or uncaptured tilingBuffer. not only prefill
| return; | ||
| } | ||
| } | ||
| // throw std::runtime_error("SetAttrStr failed, attrName not exists"); |
Collaborator
There was a problem hiding this comment.
dont comment this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accuracy test passed on GSM8K dataset
