Skip to content

Conversation

@kalyank007
Copy link
Contributor

test: Replace hardcoded CUDA device with get_device() for XPU support

Removed hardcoded "cuda" device references in test/srt/models and replaced them with get_device() calls to support XPU and other devices.

Removed hardcoded "cuda" device references in test/srt/models and
replaced them with get_device() calls to support XPU and other devices.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kalyank007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the test infrastructure by abstracting device-specific calls. By replacing direct references to "cuda" with a utility function, the tests can now seamlessly adapt to different hardware platforms, such as XPU, without requiring manual code changes. This significantly enhances the portability and future-proofing of the test suite.

Highlights

  • Device Agnostic Testing: Replaced hardcoded "cuda" device references in test runners with get_device() calls.
  • Enhanced Device Support: This change enables the test suite to run on various devices, including XPU, improving flexibility and broader hardware compatibility.
  • Code Modernization: Standardized device assignment within test utilities by leveraging a common get_device() function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively replaces hardcoded "cuda" device references with get_device() calls in python/sglang/test/runners.py. The changes are consistent and correctly implemented, making the test runners more device-agnostic and enabling support for devices like XPU. The refactoring is clean and well-scoped. I have reviewed the changes and found no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant