Skip to content

chore: make syslog-tracing optional #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2025
Merged

chore: make syslog-tracing optional #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ dns-over-h3 = ["shadowsocks-service/dns-over-h3"]
# Enable logging output
logging = [
"log4rs",
"syslog-tracing",
"tracing",
"tracing-subscriber",
"time",
Expand Down Expand Up @@ -249,7 +250,7 @@ windows-service = { version = "0.8", optional = true }

[target.'cfg(unix)'.dependencies]
xdg = "3.0"
syslog-tracing = "0.3"
syslog-tracing = { version = "0.3", optional = true }

[target.'cfg(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"))'.dependencies]
reqwest = { version = "0.12", features = [
Expand Down
6 changes: 2 additions & 4 deletions src/logging/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,8 @@ fn make_syslog_writer(bin_name: &str, config: &LogSyslogWriterConfig) -> Syslog
let options = Options::default();
let identity = CString::new(identity).expect("syslog identity contains null-byte ('\\0')");

let syslogger = match Syslog::new(identity, options, facility) {
match Syslog::new(identity, options, facility) {
Some(l) => l,
None => panic!("syslog is already initialized"),
};

syslogger
}
}
Loading