fix: URL encode Overseerr search queries#2
Open
ericboehs wants to merge 1 commit into
Open
Conversation
Overseerr's API rejects search queries containing spaces or special characters with HTTP 400 unless they are pre-encoded. This adds explicit URL encoding using urllib.parse.quote() before passing the query parameter to httpx. Fixes searches like "The Santa Clause" or "Miracle on 34th Street" that previously failed with "Parameter 'query' must be url encoded".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urllib.parse.quote()before passing the query to httpxProblem
Searches like "The Santa Clause" or "Miracle on 34th Street" fail with:
Solution
Pre-encode the query parameter in
search_media()before it's passed to the HTTP client.Test plan