Add line-backed parameter values with --parameter-file - #908
Open
220nightmore-spec wants to merge 1 commit into
Open
Add line-backed parameter values with --parameter-file#908220nightmore-spec wants to merge 1 commit into
220nightmore-spec wants to merge 1 commit into
Conversation
|
Since Sharkdp, the owner of Hyperfine, seems to no longer be maintaining it, I've decided that as long as this PR does what I need it to do and neither of the other two get merged before August 18th, I'll pay out the full bounty to all 3 of the people who've submitted PRs for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--parameter-file <VAR> <FILE>for using LF- or CRLF-delimited file lines as parameter values--parameter-listCartesian-product order and allow list/file sources to be interspersedThe initial file pass counts values so command-name and per-command option validation still know the benchmark count. Iteration then reopens the file and reads one line at a time. Benchmark results remain retained as before for comparison and export; this change removes eager retention of the input file values and generated
Commandproduct.Validation
cargo fmt -- --checkcargo +1.88.0 clippy --locked --all-targetscargo +1.88.0 check --locked --target i686-pc-windows-msvccargo build --locked --releasegit diff --checkFixes #813.