Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ssh,pkg): convert recorded session to events, to Asciinema format and save on object storage #4633

Merged
merged 8 commits into from
Mar 24, 2025
Merged

refactor(ssh,pkg): convert recorded session to events, to Asciinema format and save on object storage #4633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c0251a8
refactor(ssh,pkg): convert recorded session to events
henrybarreto Mar 10, 2025
1f6758e
chore(ssh,pkg): move ssh event structures to models
henrybarreto Mar 11, 2025
82f4118
feature(api): add store methods to list and delete events
henrybarreto Mar 11, 2025
4c506a8
feature(api,ssh,pkg): add update to the recorded session's status
henrybarreto Mar 12, 2025
6e30f9e
feature(pkg): add internal route to save session as an asciinema file
henrybarreto Mar 17, 2025
5712234
chore(cli,api,ssh): run go mod tidy
henrybarreto Mar 18, 2025
0dbc4f0
feature(ssh): save asciinema file when session is finished
henrybarreto Mar 19, 2025
9f39fef
feature(api,pkg): add migrations to convert recorded sesisons into As…
henrybarreto Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ require (
github.com/xakep666/mongo-migrate v0.3.2
go.mongodb.org/mongo-driver v1.17.3
golang.org/x/crypto v0.33.0
golang.org/x/sync v0.11.0
)

require (
Expand Down Expand Up @@ -121,7 +122,6 @@ require (
go.opentelemetry.io/otel/trace v1.26.0 // indirect
go4.org v0.0.0-20200411211856-f5505b9728dd // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/sync v0.11.0 // indirect
golang.org/x/sys v0.30.0 // indirect
golang.org/x/text v0.22.0 // indirect
golang.org/x/time v0.8.0 // indirect
Expand Down
3 changes: 2 additions & 1 deletion api/routes/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func (h *Handler) UpdateSession(c gateway.Context) error {
}

return h.service.UpdateSession(c.Ctx(), models.UID(req.UID), models.SessionUpdate{
Recorded: req.Recorded,
Authenticated: req.Authenticated,
Type: req.Type,
})
Expand Down Expand Up @@ -133,7 +134,7 @@ func (h *Handler) EventSession(c gateway.Context) error {

return h.service.EventSession(c.Ctx(), models.UID(req.UID), &models.SessionEvent{
Session: req.UID,
Type: req.Type,
Type: models.SessionEventType(req.Type),
Timestamp: req.Timestamp,
Data: req.Data,
Seat: req.Seat,
Expand Down
4 changes: 4 additions & 0 deletions api/services/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ func (s *service) UpdateSession(ctx context.Context, uid models.UID, model model
sess.Type = *model.Type
}

if model.Recorded != nil {
sess.Recorded = *model.Recorded
}

if err := s.store.SessionUpdate(ctx, uid, sess); err != nil {
return err
}
Expand Down
58 changes: 56 additions & 2 deletions api/store/mocks/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions api/store/mongo/migrations/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ func GenerateMigrations() []migrate.Migration {
migration92,
migration93,
migration94,
migration95,
migration96,
migration97,
}
}

Expand Down
Loading
Loading