Skip to content

refactor(ui): refactor new Snackbar component #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Conversation

luizhf42
Copy link
Contributor

@luizhf42 luizhf42 commented May 6, 2025

This PR refactors the Snackbar system in the Community edition to, in the future, replace the previous setup, built around four components and a dedicated store, with a simplified, plugin-based approach using a single component.

This sets the foundation for migrating existing components and views to the new system. That migration, along with test updates, will follow in subsequent PRs after this one is approved.

@luizhf42 luizhf42 self-assigned this May 6, 2025
@luizhf42 luizhf42 added area/ui status/work-in-progress javascript Pull requests that update Javascript code kind/refactor labels May 6, 2025
@luizhf42 luizhf42 force-pushed the refactor/snackbar branch 2 times, most recently from 378d6b6 to cdadbcc Compare May 7, 2025 13:03
@luizhf42 luizhf42 changed the title refactor(ui): refactor Snackbar component refactor(ui): refactor new Snackbar component May 7, 2025
@luizhf42 luizhf42 marked this pull request as ready for review May 7, 2025 13:13
@luizhf42 luizhf42 requested a review from a team as a code owner May 7, 2025 13:13
@luizhf42 luizhf42 force-pushed the refactor/snackbar branch from cdadbcc to e650d66 Compare May 7, 2025 13:17
@luizhf42 luizhf42 requested a review from otavio May 7, 2025 13:22
This commit updates the new Snackbar implementation, based on a plugin.
The new component, the plugin, and its helper were updated.
The component was added to `AppLayout.vue`, along with the old Snackbar.
@luizhf42 luizhf42 force-pushed the refactor/snackbar branch from e650d66 to 6b4f730 Compare May 7, 2025 15:01
@otavio otavio merged commit 2cbeebc into master May 7, 2025
8 checks passed
@otavio otavio deleted the refactor/snackbar branch May 7, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants