feat: Implement step persistence in wizard component - #5130
Open
micanipho wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
👮 Files not reviewed due to content moderation or server errors (5)
Warning Walkthrough skippedFile diffs could not be summarized. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for persisting the current step in the wizard component, allowing users to stay on the same step after a page refresh (on a per-browser-tab basis). Step persistence is opt-in via a new
persistCurrentStepflag, which is enabled by default for new and existing wizards. The implementation is careful to avoid persisting steps in the form designer and inside modals. The logic for step selection and persistence is refactored into a new utility module for easier testing and code clarity.Wizard step persistence:
persistCurrentStepboolean property toIWizardComponentProps, with UI support in the settings form and defaulting totruefor new and existing wizards. [1] [2] [3] [4]persistCurrentStepis enabled, restoring it after a page refresh. Persistence is disabled in the designer and in modals to avoid context issues. [1] [2]Step selection logic refactoring:
stepSelection.ts, including helpers likegetDefaultStepIndex,getInitialStepIndex,isValidStepIndex, andshouldPersistStep. [1] [2] [3]Related to issue (#4574)