Skip to content

add spelling check switch - #5482

Open
HackGenesis wants to merge 1 commit into
shesha-io:mainfrom
HackGenesis:derik/feature/4918
Open

add spelling check switch#5482
HackGenesis wants to merge 1 commit into
shesha-io:mainfrom
HackGenesis:derik/feature/4918

Conversation

@HackGenesis

@HackGenesis HackGenesis commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

#4918

Summary by CodeRabbit

  • New Features
    • Added a Spell Check option to the rich-text editor’s settings.
    • Users can enable browser-based spell checking for editor content.
    • Added a tooltip explaining how spell checking works.
    • Spell checking is independently configurable and remains disabled by default unless enabled.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 761fbd32-a6a4-4fd1-869d-faa079fadd23

📥 Commits

Reviewing files that changed from the base of the PR and between fdf8886 and dfed15a.

📒 Files selected for processing (2)
  • shesha-reactjs/src/designer-components/richTextEditor/formSettings.ts
  • shesha-reactjs/src/designer-components/richTextEditor/index.tsx

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The rich-text editor now exposes a Spell Check switch in its Options settings. The editor passes this setting through the spellcheck configuration property while keeping disablePlugins limited to explicitly disabled plugins.

Changes

Rich-text editor spell check

Layer / File(s) Summary
Spell-check configuration
shesha-reactjs/src/designer-components/richTextEditor/formSettings.ts, shesha-reactjs/src/designer-components/richTextEditor/index.tsx
The Options panel adds a Spell Check switch with a browser spell-check tooltip. The editor configures spellcheck separately and defaults it to false. disablePlugins no longer adds spellcheck implicitly.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to dfed1

The rich-text editor now exposes a browser spell-check option while preserving explicit plugin-disable behavior. No current merge-blocking risk remains.

Suggested reviewers: ivanilyichev

Poem

A rabbit taps the Spell Check switch
Browser words now hop into line
Disabled plugins stay as set
The editor keeps its options clear
Soft paws approve the tidy change

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a spelling check switch to the rich text editor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant