Symfony: allow explicit containerXmlPaths configuration#325
Merged
janedbal merged 1 commit intoshipmonk-rnd:masterfrom Mar 25, 2026
Merged
Symfony: allow explicit containerXmlPaths configuration#325janedbal merged 1 commit intoshipmonk-rnd:masterfrom
containerXmlPaths configuration#325janedbal merged 1 commit intoshipmonk-rnd:masterfrom
Conversation
ruudk
force-pushed
the
config-containerXmlPath
branch
from
c964fc6 to
d703138
Compare
janedbal
requested changes
Mar 25, 2026
ruudk
force-pushed
the
config-containerXmlPath
branch
from
d703138 to
ba51bb0
Compare
ruudk
changed the title
containerXmlPath configurationcontainerXmlPaths configuration
Member
|
Also, readme should state it, sth like: |
When using phpstan-symfony, its `SymfonyContainerResultCacheMetaExtension` causes a full PHPStan rerun whenever any dependency changes. On large projects this is a significant slowdown. This option allows configuring `containerXmlPaths` directly in dead-code-detector's config, decoupling it from phpstan-symfony's `containerXmlPath` parameter. This way, users can remove phpstan-symfony's container config to avoid the cache invalidation penalty while still getting accurate DIC-based dead code detection. Accepts `list<string>` to support multiple environments. See: phpstan/phpstan-symfony#455 See: phpstan/phpstan-symfony#421
ruudk
force-pushed
the
config-containerXmlPath
branch
from
ba51bb0 to
7bdb015
Compare
Contributor
Author
|
@janedbal Thanks for the review. Applied your feedback. |
janedbal
approved these changes
Mar 25, 2026
Contributor
Author
|
Thanks for the fast merge ⚡ If possible, would you mind tagging it? 🙏 |
Member
|
I'll probably call this package stable soon, so next will be 1.0.0 - better to think twice before commitment. |
Contributor
Author
|
Would it be better for me to pin to dev-master then? |
Member
|
I expect tag max within a week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using phpstan-symfony, its
SymfonyContainerResultCacheMetaExtensioncauses a full PHPStan rerun whenever any dependency changes. On large projects this is a significant slowdown.This option allows configuring
containerXmlPathsdirectly in dead-code-detector's config, decoupling it from phpstan-symfony'scontainerXmlPathparameter. This way, users can remove phpstan-symfony's container config to avoid the cache invalidation penalty while still getting accurate DIC-based dead code detection.Accepts
list<string>to support multiple environments.See: phpstan/phpstan-symfony#455
See: phpstan/phpstan-symfony#421