Skip to content

Various edits related to CI #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/ci-common-setup-locally-packaged/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Reusable common setup with locally packaged library code for projec

inputs:
node-version:
description: Specific Node.js version to override the common one that's gonna be selected by default
description: Optional specific Node.js version to install (default is v22.5.0)
required: false
default: v22.5.0

Expand Down Expand Up @@ -36,7 +36,7 @@ runs:
PACKAGE_FILENAME=$(ls ${{ steps.package-json-info.outputs.package_name }}-${{ steps.package-json-info.outputs.package_version }}.tgz)
pnpm i packaged-react-async-iterators@file:./$PACKAGE_FILENAME

- name: Type-check tests code
- name: Redirect code entrypoint from the source code to packaged code
shell: bash
run: |
[[ -e ./src ]] && mv ./src ./src-ignored-for-packaged-testing
Expand Down
8 changes: 4 additions & 4 deletions .github/actions/ci-common-setup/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ description: Reusable common setup for project's CI jobs

inputs:
node-version:
description: Specific Node.js version to override the common one that's gonna be selected by default
description: Optional specific Node.js version to install (default is v22.5.0)
required: false
default: v22.5.0

runs:
using: composite
steps:
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node-version }}

- name: Get Node.js version
id: node_version
shell: bash
run: echo "version=$(node -v)" >>$GITHUB_OUTPUT
run: echo "version=$(node -v)" >> $GITHUB_OUTPUT

- name: Get package manager type and version from `package.json`
id: pkg_manager_value
Expand All @@ -33,7 +33,7 @@ runs:

- name: Restore possibly cached dependencies
id: cache-node-modules
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ./node_modules
key: node-modules-${{ runner.os }}-${{ steps.node_version.outputs.version }}-${{ hashFiles('./pnpm-lock.yaml') }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-ts-build-check.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI - ts build check
name: CI - TypeScript build check

on:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"test-typings-check": "tsc --noEmit -p ./spec/tsconfig.json",
"build": "rm -rf ./dist && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && tsx ./scripts/set-module-type-in-dist-builds.ts",
"build-check": "tsc --noEmit -p ./tsconfig.json",
"prepack": "npm run build"
"prepack": "pnpm run build"
},
"peerDependencies": {
"react": ">=17"
Expand Down
Loading