Skip to content

Issue #74: unsubscribe error fix#78

Open
dimafern wants to merge 1 commit into
shumkov:masterfrom
dimafern:master
Open

Issue #74: unsubscribe error fix#78
dimafern wants to merge 1 commit into
shumkov:masterfrom
dimafern:master

Conversation

@dimafern

Copy link
Copy Markdown

Issue #74: unsubscribe error fix

Issue #74: unsubscribe error fix
@shumkov

shumkov commented Aug 7, 2013

Copy link
Copy Markdown
Owner

We already discuss this:

ME: Connection from prev foreach may be wrong, if channels from different connections
YOU:OK, but the problem is when you unsubscribe the connection is removed from connections list and you can't find it with getConnectionByAlias later.
ME: Than move $this->_connections->removeChannel($channel) after the getting responses.

@dimafern

dimafern commented Aug 7, 2013

Copy link
Copy Markdown
Author

$channel = $this->rediska->subscribe('bets', 60);
$channel->unsubscribe();
Just subscribe and then unsubscribe

More detailed description is here
#74

On Aug 7, 2013, at 15:52 , Ivan Shumkov notifications@github.com wrote:

How can i reproduce this bug?


Reply to this email directly or view it on GitHub.

@shumkov

shumkov commented Aug 7, 2013

Copy link
Copy Markdown
Owner

Ok thanks, but your solution is wrong if we have a channels with different connections

@dimafern

dimafern commented Aug 8, 2013

Copy link
Copy Markdown
Author

Probably yes, it's wrong. It works for me with one connection.
I didn;t fix it for multiple connections.

On Aug 7, 2013, at 19:09 , Ivan Shumkov notifications@github.com wrote:

Ok, but your solution is wrong if we have a channels with different connections


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants