make Lock operations retriable#314
Open
diaxoaine wants to merge 1 commit intosibson:mainfrom
Open
Conversation
Owner
|
Is there a reason the getattr() isn't properly wrapping lock() to be retry-able? |
2aff0f5 to
794b3d6
Compare
Author
it's because getattr() only wraps first-level method calls on the RetryingConnection. The returned objects of these method calls aren't bound to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the
retry_periodconfig doesn't apply to theself.lockobject so if the Redis connection breaks right beforetick()runs,self.lock.extend()throws an exception and beat stops.This PR makes lock operations retriable when
retry_periodis set.